Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: components/browser_watcher/postmortem_minidump_writer_win.cc

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/postmortem_minidump_writer_win.cc
diff --git a/components/browser_watcher/postmortem_minidump_writer_win.cc b/components/browser_watcher/postmortem_minidump_writer_win.cc
index 3e6a2d8da31ab48add26dc3f16c5cffa87202aaa..7169465fcb92ebec98763a912e9b26b0b9ac92df 100644
--- a/components/browser_watcher/postmortem_minidump_writer_win.cc
+++ b/components/browser_watcher/postmortem_minidump_writer_win.cc
@@ -198,7 +198,9 @@ bool PostmortemMinidumpWriter::WriteDumpImpl(
// current executable's values are an (imperfect) proxy.
std::map<std::string, std::string> crash_keys = {
{"product", minidump_info.product_name + "_Postmortem"},
grt (UTC plus 2) 2016/09/26 18:59:06 shouldn't this be "prod" (https://cs.chromium.org/
manzagop (departed) 2016/09/27 19:37:52 IIUC those are the deprecated keys, but it's proba
- {"version", minidump_info.version_number}};
+ {"version", minidump_info.version_number},
grt (UTC plus 2) 2016/09/26 18:59:06 "ver" (https://cs.chromium.org/chromium/src/compon
manzagop (departed) 2016/09/27 19:37:52 Done.
+ {"channel", minidump_info.channel_name},
+ {"plat", minidump_info.platform}};
if (!AppendCrashpadInfo(minidump_info.client_id, minidump_info.report_id,
crash_keys))
return false;

Powered by Google App Engine
This is Rietveld 408576698