Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/browser_watcher/postmortem_minidump_writer.h

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Pass strings to PostmortemReportCollector's ctor Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browser_watcher/DEPS ('k') | components/browser_watcher/postmortem_minidump_writer_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/postmortem_minidump_writer.h
diff --git a/components/browser_watcher/postmortem_minidump_writer.h b/components/browser_watcher/postmortem_minidump_writer.h
index 74297de45ebca86af8f5e30e59992b183b503ee6..17a345c35840c618ede5ce52853aeec5e704c125 100644
--- a/components/browser_watcher/postmortem_minidump_writer.h
+++ b/components/browser_watcher/postmortem_minidump_writer.h
@@ -21,6 +21,8 @@ struct MinidumpInfo {
crashpad::UUID report_id; // The report's identifier.
std::string product_name; // The product name to be used by the reporter.
std::string version_number; // The product's version number.
+ std::string channel_name; // The name of the channel.
rkaplow 2016/09/30 14:41:54 Can we point to any authoritative source on what t
manzagop (departed) 2016/09/30 18:54:20 I was more specific in the comment, though more on
+ std::string platform; // The platform identifier.
};
// Write to |minidump_file| a minimal minidump that wraps |report|. Returns
« no previous file with comments | « components/browser_watcher/DEPS ('k') | components/browser_watcher/postmortem_minidump_writer_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698