Use the correct product/version for postmortem reports

chrome/browser/metrics/chrome_metrics_service_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
 
 #include <stddef.h>
 
 #include <vector>
 
@@ skipping 16 matching lines @@
 #include "chrome/browser/google/google_brand.h"
 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
 #include "chrome/browser/metrics/chrome_stability_metrics_provider.h"
 #include "chrome/browser/metrics/https_engagement_metrics_provider.h"
 #include "chrome/browser/metrics/metrics_reporting_state.h"
 #include "chrome/browser/metrics/sampling_metrics_provider.h"
 #include "chrome/browser/metrics/subprocess_metrics_provider.h"
 #include "chrome/browser/metrics/time_ticks_experiment_win.h"
 #include "chrome/browser/sync/chrome_sync_client.h"
 #include "chrome/browser/ui/browser_otr_state.h"
+#include "chrome/chrome_watcher/chrome_postmortem_report_collector.h"
 #include "chrome/common/channel_info.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/crash_keys.h"
 #include "chrome/common/features.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/installer/util/util_constants.h"
 #include "components/metrics/call_stack_profile_metrics_provider.h"
 #include "components/metrics/drive_metrics_provider.h"
@@ skipping 446 matching lines @@
   base::FilePath user_data_dir;
   base::FilePath crash_dir;
   if (!base::PathService::Get(chrome::DIR_USER_DATA, &user_data_dir) ||
       !base::PathService::Get(chrome::DIR_CRASH_DUMPS, &crash_dir)) {
     // If either call fails, then clear both.
     user_data_dir = base::FilePath();
     crash_dir = base::FilePath();
   }
   watcher_metrics_provider_ = new browser_watcher::WatcherMetricsProviderWin(
       chrome::GetBrowserExitCodesRegistryPath(), user_data_dir, crash_dir,
+      base::WrapUnique(new chrome_watcher::ChromePostmortemReportCollector()),

[grt (UTC plus 2), 2016/09/27 20:43:09]

base::MakeUnique<chrome_watcher::ChromePostmortemReportCollector>()

that aside, i think that making Chrome aware of PRC is unfortunate due to the
dependency leakage. since what is really needed here is a way for Chrome to pass
three values to the watcher, can you either pass the values directly here, or
provide a callback that returns them when needed? for example, in an anonymous
namespace in this file:

void GetTheValues(std::string* one, std::string* two, std::string* three) {
  // use install_static to fetch the data
}

and then here:
  base::Bind(&GetTheValues)

and then inside of the WMPW:

  callback_.Run(&one, &two, &three);

[manzagop (departed), 2016/09/28 16:29:17]

Agreed that is better. Done.

       content::BrowserThread::GetBlockingPool());
   metrics_service_->RegisterMetricsProvider(
       std::unique_ptr<metrics::MetricsProvider>(watcher_metrics_provider_));
 
   antivirus_metrics_provider_ = new AntiVirusMetricsProvider(
       content::BrowserThread::GetBlockingPool()
           ->GetTaskRunnerWithShutdownBehavior(
               base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN));
 
   metrics_service_->RegisterMetricsProvider(
@@ skipping 303 matching lines @@
   }
 }
 
 void ChromeMetricsServiceClient::OnURLOpenedFromOmnibox(OmniboxLog* log) {
   metrics_service_->OnApplicationNotIdle();
 }
 
 bool ChromeMetricsServiceClient::IsUMACellularUploadLogicEnabled() {
   return metrics::IsCellularLogicEnabled();
 }