Use the correct product/version for postmortem reports

chrome/app/chrome_crash_reporter_client_win.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
 #define CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
 
 #include "base/macros.h"
+#include "base/strings/string16.h"
 #include "components/crash/content/app/crash_reporter_client.h"
 
 class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
  public:
 #if !defined(NACL_WIN64)
   // Instantiates a process wide instance of the ChromeCrashReporterClient
   // class and initializes crash reporting for the process. The instance is
   // leaked.
   static void InitializeCrashReportingForProcess();
 #endif
@@ skipping 26 matching lines @@
 
   bool GetCollectStatsConsent() override;
 
   bool GetCollectStatsInSample() override;
 
   bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override;
 
   bool EnableBreakpadForProcess(const std::string& process_type) override;
 
  private:
+  // Cached to ensure consistency across calls and because the functions that

[grt (UTC plus 2), 2016/09/26 18:59:06]

while i think this caching is ultimately the right thing, i'm not sure it's
needed right now. this choice means that you must get the one true CCRC for the
process in your own code. as per my comment in the other file, i'm not sure you
can. without trying to solve this problem here, you could call install_static
directly. it may be the case that the magic install_static function will
automagically do the once-per-process thing. since crash isn't the only consumer
of these values, i think this is the wrong place to do the caching anyway.

[manzagop (departed), 2016/09/27 19:37:52]

I've made the switch to directly call install static. Because that's in chrome/,
I couldn't do so in the component and I ended up writing a derived collector in
chrome/chrome_watcher that implements some pure functions to get the details.

+  // populate these are known to unexpectedly experience crashes on some users'
+  // machines.
+  base::string16 exe_path_;
+  base::string16 product_name_;
+  base::string16 version_;
+  base::string16 special_build_;
+  base::string16 channel_name_;
+
   DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient);
 };
 
 #endif  // CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_