Use the correct product/version for postmortem reports

chrome/app/chrome_crash_reporter_client_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(ananta/scottmg)
 // Add test coverage for Crashpad.
 #include "chrome/app/chrome_crash_reporter_client_win.h"
 
 #include <assert.h>
 #include <windows.h>
@@ skipping 243 matching lines @@
 void ChromeCrashReporterClient::GetProductNameAndVersion(
     const base::string16& exe_path,
     base::string16* product_name,
     base::string16* version,
     base::string16* special_build,
     base::string16* channel_name) {
   assert(product_name);
   assert(version);
   assert(special_build);
   assert(channel_name);
+  DCHECK(!exe_path.empty());  // The empty string is not a valid path.
 
-  install_static::GetExecutableVersionDetails(
-      exe_path, product_name, version, special_build, channel_name);
+  // Defend against unexpected use of function with varying |exe_path|.
+  if (!exe_path_.empty()) {
+    DCHECK_EQ(exe_path_, exe_path);
+    if (exe_path_ != exe_path)

[grt (UTC plus 2), 2016/09/26 18:59:06]

don't DCHECK and then handle the DCHECKed case as per
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md....
either DCHECK and move on, or CHECK. i propose adding DCHECK(exe_path_.empty()
|| exe_path_ == exe_path); after line 265 and getting rid of this defensive
block.

[manzagop (departed), 2016/09/27 19:37:52]

Thanks for the pointer!

Due to the changes, comment no longer applies. Ack.

+      exe_path_.clear();  // Clear the cache.
+  }
+
+  // Populate the cache.
+  if (exe_path_.empty()) {
+    exe_path_ = exe_path;
+    install_static::GetExecutableVersionDetails(
+        exe_path_, &product_name_, &version_, &special_build_, &channel_name_);
+  }
+
+  // Serve from the cache.
+  *product_name = product_name_;
+  *version = version_;
+  *special_build = special_build_;
+  *channel_name = channel_name_;
 }
 
 bool ChromeCrashReporterClient::ShouldShowRestartDialog(base::string16* title,
                                                         base::string16* message,
                                                         bool* is_rtl_locale) {
   if (!install_static::HasEnvironmentVariable16(
           install_static::kShowRestart) ||
       !install_static::HasEnvironmentVariable16(
           install_static::kRestartInfo)) {
     return false;
@@ skipping 104 matching lines @@
 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
   return install_static::GetCollectStatsInSample();
 }
 
 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
     const std::string& process_type) {
   return process_type == install_static::kRendererProcess ||
          process_type == install_static::kPpapiPluginProcess ||
          process_type == install_static::kGpuProcess;
 }