Use the correct product/version for postmortem reports

components/browser_watcher/watcher_metrics_provider_win.h

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_
 #define COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_
 
+#include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "base/task_runner.h"
 #include "base/threading/thread_checker.h"
 #include "components/metrics/metrics_provider.h"
 
 namespace browser_watcher {
 
 // Provides stability data captured by the Chrome Watcher, namely the browser
 // process exit codes.
 class WatcherMetricsProviderWin : public metrics::MetricsProvider {
  public:
+  using GetExecutableDetailsCallback =

[grt (UTC plus 2), 2016/09/28 19:42:45]

please provide sufficient documentation here for an implementer to know what to
do.

[manzagop (departed), 2016/09/29 15:23:14]

Done.

+      base::Callback<void(base::string16*, base::string16*, base::string16*)>;
+
   static const char kBrowserExitCodeHistogramName[];
 
   // Initializes the reporter. |io_task_runner| is used for collecting
   // postmortem reports and clearing leftover data in registry if metrics
   // reporting is disabled.
   WatcherMetricsProviderWin(const base::string16& registry_path,
                             const base::FilePath& user_data_dir,
                             const base::FilePath& crash_dir,
+                            const GetExecutableDetailsCallback& exe_details_cb,
                             base::TaskRunner* io_task_runner);
   ~WatcherMetricsProviderWin() override;
 
   // metrics::MetricsProvider implementation.
   void OnRecordingEnabled() override;
   void OnRecordingDisabled() override;
   // Note: this function collects metrics, some of which are related to the
   // previous run's version and some to the current version. Doing the correct
   // attribution on upgrade is difficult, and currently ignored. Metrics
   // clearing is one mechanism to avoid misattribution, but is not used in this
@@ skipping 14 matching lines @@
   // TODO(manzagop): avoid collecting reports for clean exits from the fast exit
   // path.
   void CollectPostmortemReportsOnBlockingPool();
 
   bool recording_enabled_;
   bool cleanup_scheduled_;
   const base::string16 registry_path_;
   const base::FilePath user_data_dir_;
   const base::FilePath crash_dir_;
   scoped_refptr<base::TaskRunner> io_task_runner_;
+  GetExecutableDetailsCallback exe_details_cb_;
   base::WeakPtrFactory<WatcherMetricsProviderWin> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WatcherMetricsProviderWin);
 };
 
 }  // namespace browser_watcher
 
 #endif  // COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_