Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2372623003: Enable vp9 high bit depth for nacl and generic (Closed)

Created:
4 years, 2 months ago by Johann
Modified:
4 years, 2 months ago
Reviewers:
hubbe
CC:
chromium-reviews, wwcv, jzern, fgalligan1, Tom Finegan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable vp9 high bit depth for nacl and generic These configs already use --target=generic-gnu which provides no optimization whatsoever. Enabling high bit depth keeps test conditions simple and allows running things like the MSAN tests. BUG=650365 Committed: https://crrev.com/0a8a58ba0e372e4a725cc25597daf7ea9589a192 Cr-Commit-Position: refs/heads/master@{#421001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1910 lines, -20 lines) Patch
M third_party/libvpx/generate_gni.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libvpx/source/config/linux/generic/vp9_rtcd.h View 3 chunks +45 lines, -6 lines 0 comments Download
M third_party/libvpx/source/config/linux/generic/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/linux/generic/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/linux/generic/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/linux/generic/vpx_dsp_rtcd.h View 1 chunk +906 lines, -0 lines 0 comments Download
M third_party/libvpx/source/config/nacl/vp9_rtcd.h View 3 chunks +45 lines, -6 lines 0 comments Download
M third_party/libvpx/source/config/nacl/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/nacl/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/nacl/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/nacl/vpx_dsp_rtcd.h View 1 chunk +906 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Johann
msan uses the linux/generic config because it has issues with some of the assembly code. ...
4 years, 2 months ago (2016-09-26 19:37:51 UTC) #3
Lei Zhang
Though I'm interested in seeing the issue fixed, I'm not qualified to review this code.
4 years, 2 months ago (2016-09-26 20:37:26 UTC) #6
Johann
switched to hubbe@
4 years, 2 months ago (2016-09-26 20:40:53 UTC) #9
hubbe
lgtm
4 years, 2 months ago (2016-09-26 21:20:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372623003/1
4 years, 2 months ago (2016-09-26 21:29:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 21:38:06 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 21:40:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a8a58ba0e372e4a725cc25597daf7ea9589a192
Cr-Commit-Position: refs/heads/master@{#421001}

Powered by Google App Engine
This is Rietveld 408576698