Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 23726041: Turn the NumberToStringStub into a hydrogen stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3531 matching lines...) Expand 10 before | Expand all | Expand 10 after
3542 3542
3543 __ bind(&done); 3543 __ bind(&done);
3544 context()->Plug(eax); 3544 context()->Plug(eax);
3545 } 3545 }
3546 3546
3547 3547
3548 void FullCodeGenerator::EmitNumberToString(CallRuntime* expr) { 3548 void FullCodeGenerator::EmitNumberToString(CallRuntime* expr) {
3549 ZoneList<Expression*>* args = expr->arguments(); 3549 ZoneList<Expression*>* args = expr->arguments();
3550 ASSERT_EQ(args->length(), 1); 3550 ASSERT_EQ(args->length(), 1);
3551 3551
3552 // Load the argument on the stack and call the stub. 3552 // Load the argument into eax and call the stub.
3553 VisitForStackValue(args->at(0)); 3553 VisitForAccumulatorValue(args->at(0));
3554 3554
3555 NumberToStringStub stub; 3555 NumberToStringStub stub;
3556 __ CallStub(&stub); 3556 __ CallStub(&stub);
3557 context()->Plug(eax); 3557 context()->Plug(eax);
3558 } 3558 }
3559 3559
3560 3560
3561 void FullCodeGenerator::EmitStringCharFromCode(CallRuntime* expr) { 3561 void FullCodeGenerator::EmitStringCharFromCode(CallRuntime* expr) {
3562 ZoneList<Expression*>* args = expr->arguments(); 3562 ZoneList<Expression*>* args = expr->arguments();
3563 ASSERT(args->length() == 1); 3563 ASSERT(args->length() == 1);
(...skipping 1405 matching lines...) Expand 10 before | Expand all | Expand 10 after
4969 ASSERT_EQ(kJnsOffset, *(call_target_address - 2)); 4969 ASSERT_EQ(kJnsOffset, *(call_target_address - 2));
4970 return INTERRUPT; 4970 return INTERRUPT;
4971 } 4971 }
4972 } 4972 }
4973 #endif // DEBUG 4973 #endif // DEBUG
4974 4974
4975 4975
4976 } } // namespace v8::internal 4976 } } // namespace v8::internal
4977 4977
4978 #endif // V8_TARGET_ARCH_IA32 4978 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698