chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc - Issue 23726016: Show non-incognito browser in front of incognito browser when signing in from bookmark bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

Issue 23726016: Show non-incognito browser in front of incognito browser when signing in from bookmark bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc » ('j') | chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc b/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

index cb2d7239f322cf207d094bd6fb75dc68e603a703..f937c0da92b003b317710692afea679a1436c630 100644

--- a/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

@@ -26,8 +26,6 @@ BookmarkBubbleSignInDelegate::~BookmarkBubbleSignInDelegate() {

void BookmarkBubbleSignInDelegate::OnSignInLinkClicked() {

EnsureBrowser();

chrome::ShowBrowserSignin(browser_, signin::SOURCE_BOOKMARK_BUBBLE);

- DCHECK(!browser_->tab_strip_model()->empty());

- browser_->window()->Show();

}

void BookmarkBubbleSignInDelegate::OnBrowserRemoved(Browser* browser) {