Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 23726007: Remove old accessibility enums, finish renaming public interface. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove unnecessary include Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index 999d3b396ce895bb3f439cc95e406050d2b63427..a7ddf33697b1d1cd276bfe0ab07784461f2498e2 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -41,7 +41,7 @@
#include "PopupContainer.h"
#include "PopupMenuChromium.h"
#include "RuntimeEnabledFeatures.h"
-#include "WebAccessibilityObject.h"
+#include "WebAXObject.h"
#include "WebAutofillClient.h"
#include "WebColorChooser.h"
#include "WebConsoleMessage.h"
@@ -121,13 +121,6 @@ static WebPopupType convertPopupType(PopupContainer::PopupType type)
}
}
-// Converts a WebCore::AXObjectCache::AXNotification to a WebKit::WebAccessibilityNotification
-static WebAccessibilityNotification toWebAccessibilityNotification(AXObjectCache::AXNotification notification)
-{
- // These enums have the same values; enforced in AssertMatchingEnums.cpp.
- return static_cast<WebAccessibilityNotification>(notification);
-}
-
// Converts a WebCore::AXObjectCache::AXNotification to a WebKit::WebAXEvent
static WebAXEvent toWebAXEvent(AXObjectCache::AXNotification notification)
{
@@ -811,9 +804,7 @@ void ChromeClientImpl::postAccessibilityNotification(AccessibilityObject* obj, A
if (!obj)
return;
- // FIXME: Remove this first call once Chromium has switched over to using the second. (http://crbug.com/269034)
- m_webView->client()->postAccessibilityNotification(WebAccessibilityObject(obj), toWebAccessibilityNotification(notification));
- m_webView->client()->postAccessibilityEvent(WebAccessibilityObject(obj), toWebAXEvent(notification));
+ m_webView->client()->postAccessibilityEvent(WebAXObject(obj), toWebAXEvent(notification));
jamesr 2013/09/03 21:52:42 another inconsistency: postAccessibilityEvent ...
dmazzoni 2013/09/06 19:53:32 I prefer postAccessibilityEvent, but not strongly
}
String ChromeClientImpl::acceptLanguages()

Powered by Google App Engine
This is Rietveld 408576698