Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 23726005: On Windows 8 load the mfcore.dll and invoke the MFStartup API in the (Closed)

Created:
7 years, 3 months ago by ananta
Modified:
7 years, 3 months ago
CC:
chromium-reviews, jam, apatrick_chromium, piman, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

On Windows 8 load the mfcore.dll and invoke the MFStartup API in the DXVAVideoDecodeAccelerator::PreSandboxInitialization function. This is because these functions fail on Windows 8.1 in the gpu sandbox causing us to fallback to s/w video decode for H.264 videos. BUG=281752 R=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220483

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ananta
7 years, 3 months ago (2013-08-29 23:23:24 UTC) #1
scherkus (not reviewing)
lgtm w/ nit https://codereview.chromium.org/23726005/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc File content/common/gpu/media/dxva_video_decode_accelerator.cc (right): https://codereview.chromium.org/23726005/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc#newcode403 content/common/gpu/media/dxva_video_decode_accelerator.cc:403: // sandbox end sentences with periods.
7 years, 3 months ago (2013-08-29 23:56:00 UTC) #2
scherkus (not reviewing)
also ... do we have any win8 bots that could have caught this?
7 years, 3 months ago (2013-08-29 23:56:16 UTC) #3
ananta
We have a windows 8 bot which runs aura tests. No DXVA tests though. https://codereview.chromium.org/23726005/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc ...
7 years, 3 months ago (2013-08-30 02:21:14 UTC) #4
ananta
7 years, 3 months ago (2013-08-30 02:26:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r220483 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698