Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4845)

Unified Diff: build/android/pylib/instrumentation/test_runner.py

Issue 23726004: Add test_server_setup.py and add support for additional flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/instrumentation/test_runner.py
diff --git a/build/android/pylib/instrumentation/test_runner.py b/build/android/pylib/instrumentation/test_runner.py
index 9599b25cd5b70d746742267f165d530b007e1527..212f4a477a69e1bfca51d7b8b172ef1f9484e377 100644
--- a/build/android/pylib/instrumentation/test_runner.py
+++ b/build/android/pylib/instrumentation/test_runner.py
@@ -52,7 +52,7 @@ class TestRunner(base_test_runner.BaseTestRunner):
_DEVICE_HAS_TEST_FILES = {}
def __init__(self, test_options, device, shard_index, test_pkg,
- ports_to_forward):
+ ports_to_forward, additional_flags=[]):
frankf 2013/08/29 00:07:19 use None instead of empty list when piping this th
nyquist 2013/08/29 23:59:43 Done.
"""Create a new TestRunner.
Args:
@@ -62,6 +62,7 @@ class TestRunner(base_test_runner.BaseTestRunner):
test_pkg: A TestPackage object.
ports_to_forward: A list of port numbers for which to set up forwarders.
Can be optionally requested by a test case.
+ additional_flags: A list of addition flags to add to the command line.
"""
super(TestRunner, self).__init__(device, test_options.tool,
test_options.push_deps,
@@ -80,6 +81,8 @@ class TestRunner(base_test_runner.BaseTestRunner):
self.flags = flag_changer.FlagChanger(self.adb, cmdline_file[0])
else:
self.flags = flag_changer.FlagChanger(self.adb)
+ if len(additional_flags):
craigdh 2013/08/29 00:06:46 no need for len(), just "if additional_flags:"
nyquist 2013/08/29 23:59:43 Done.
+ self.flags.AddFlags(additional_flags)
#override
def InstallTestPackage(self):

Powered by Google App Engine
This is Rietveld 408576698