Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2372573006: Disable eager tracing for NGPhysicalFragment. (Closed)

Created:
4 years, 2 months ago by Gleb Lanbin
Modified:
4 years, 2 months ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable eager tracing for NGPhysicalFragment. By default Oilpan has a limit on stackFrameDepth while tracing HeapVector. Wrap NGPhysicalFragment into TraceEagerlyTrait class to fix that. BUG=635619 Committed: https://crrev.com/80fe8dbc114625ffa8d7edb1f2443d82d298b03b Cr-Commit-Position: refs/heads/master@{#421263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Gleb Lanbin
4 years, 2 months ago (2016-09-27 16:16:02 UTC) #2
cbiesinger
lgtm
4 years, 2 months ago (2016-09-27 16:39:14 UTC) #5
ikilpatrick
lgtm \o/
4 years, 2 months ago (2016-09-27 16:52:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372573006/1
4 years, 2 months ago (2016-09-27 17:57:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 18:05:55 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 18:09:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80fe8dbc114625ffa8d7edb1f2443d82d298b03b
Cr-Commit-Position: refs/heads/master@{#421263}

Powered by Google App Engine
This is Rietveld 408576698