chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h - Issue 2372573005: Update OnCommit to return ObservePolicy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)

Patch Set: add tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

index 5b751a1a36357d3b9e5c65d327b0292e0101a4cf..5091bd2c0482cc24c522d224953e70b54f767f57 100644

--- a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

@@ -15,16 +15,11 @@ class StaleWhileRevalidateMetricsObserver

public:

StaleWhileRevalidateMetricsObserver();

// page_load_metrics::PageLoadMetricsObserver implementation:

- void OnCommit(content::NavigationHandle* navigation_handle) override;

+ ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;

void OnComplete(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) override;

- private:

- // True if the committed URL is one of the domains of interest to the

- // stale-while-revalidate experiment.

- bool is_interesting_domain_;

DISALLOW_COPY_AND_ASSIGN(StaleWhileRevalidateMetricsObserver);

};