Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Issue 2372563002: Adding Embedding-CSP HTTP header (Closed)
Patch Set: Separating into two functions Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
index 9bfc1b0d6a358d2afddf45b71d395c386ecb7b62..fb86610fcb43fb6fadde40018102ca229f263730 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
@@ -184,7 +184,7 @@ protected:
fetchRequest.mutableResourceRequest().setRequestContext(requestContext);
fetchRequest.mutableResourceRequest().setFrameType(frameType);
- fetchContext->upgradeInsecureRequest(fetchRequest.mutableResourceRequest());
+ fetchContext->addOutgoingSecurityHeadersAndUpgradeRequest(fetchRequest.mutableResourceRequest());
Mike West 2016/10/06 08:00:51 Please add tests in this file for the header you'r
EXPECT_EQ(expectedURL.getString(), fetchRequest.resourceRequest().url().getString());
EXPECT_EQ(expectedURL.protocol(), fetchRequest.resourceRequest().url().protocol());
@@ -202,14 +202,14 @@ protected:
fetchRequest.mutableResourceRequest().setRequestContext(WebURLRequest::RequestContextScript);
fetchRequest.mutableResourceRequest().setFrameType(frameType);
- fetchContext->upgradeInsecureRequest(fetchRequest.mutableResourceRequest());
+ fetchContext->addOutgoingSecurityHeadersAndUpgradeRequest(fetchRequest.mutableResourceRequest());
EXPECT_EQ(shouldPrefer ? String("1") : String(),
fetchRequest.resourceRequest().httpHeaderField(HTTPNames::Upgrade_Insecure_Requests));
// Calling upgradeInsecureRequest more than once shouldn't affect the header.
if (shouldPrefer) {
- fetchContext->upgradeInsecureRequest(fetchRequest.mutableResourceRequest());
+ fetchContext->addOutgoingSecurityHeadersAndUpgradeRequest(fetchRequest.mutableResourceRequest());
EXPECT_EQ("1", fetchRequest.resourceRequest().httpHeaderField(HTTPNames::Upgrade_Insecure_Requests));
}
}

Powered by Google App Engine
This is Rietveld 408576698