[stubs] Add SmiMax and refactor SmiMin to use Select

src/code-stub-assembler.cc

Index: src/code-stub-assembler.cc
diff --git a/src/code-stub-assembler.cc b/src/code-stub-assembler.cc
index e81b04dd44b80bcd17bd4a7a2088fb0995449f95..f8b344d2fde89dd8ae46bc1da8c274f2278be9ef 100644
--- a/src/code-stub-assembler.cc
+++ b/src/code-stub-assembler.cc
@@ -357,18 +357,15 @@ Node* CodeStubAssembler::SmiLessThanOrEqual(Node* a, Node* b) {
   return IntPtrLessThanOrEqual(a, b);
 }
 
+Node* CodeStubAssembler::SmiMax(Node* a, Node* b) {
+  Variable max(this, MachineRepresentation::kTagged);
+  max.Bind(Select(SmiLessThan(a, b), b, a));

[Igor Sheludko, 2016/09/27 11:40:03]

I guess you can just return a Select node.

[jgruber, 2016/09/27 13:35:46]

Done.

+  return max.value();
+}
+
 Node* CodeStubAssembler::SmiMin(Node* a, Node* b) {
-  // TODO(bmeurer): Consider using Select once available.
   Variable min(this, MachineRepresentation::kTagged);
-  Label if_a(this), if_b(this), join(this);
-  BranchIfSmiLessThan(a, b, &if_a, &if_b);
-  Bind(&if_a);
-  min.Bind(a);
-  Goto(&join);
-  Bind(&if_b);
-  min.Bind(b);
-  Goto(&join);
-  Bind(&join);
+  min.Bind(Select(SmiLessThan(a, b), a, b));

[Igor Sheludko, 2016/09/27 11:40:03]

Same here.

[jgruber, 2016/09/27 13:35:46]

Done.

   return min.value();
 }