Chromium Code Reviews

Issue 2372543002: [stubs] Add SmiMax and refactor SmiMin to use Select (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer, Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add SmiMax and refactor SmiMin to use Select SmiMax will be used in a follow-up commit. BUG= Committed: https://crrev.com/f26c4d2d5510fab1a611547e03ff582032b86649 Cr-Commit-Position: refs/heads/master@{#39783}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Stats (+6 lines, -12 lines)
M src/code-stub-assembler.h View 1 chunk +1 line, -0 lines 0 comments
M src/code-stub-assembler.cc View 1 chunk +5 lines, -12 lines 0 comments

Messages

Total messages: 21 (12 generated)
jgruber
4 years, 2 months ago (2016-09-26 11:59:19 UTC) #4
Igor Sheludko
https://codereview.chromium.org/2372543002/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2372543002/diff/1/src/code-stub-assembler.cc#newcode362 src/code-stub-assembler.cc:362: max.Bind(Select(SmiLessThan(a, b), b, a)); I guess you can just ...
4 years, 2 months ago (2016-09-27 11:40:03 UTC) #7
jgruber
https://codereview.chromium.org/2372543002/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2372543002/diff/1/src/code-stub-assembler.cc#newcode362 src/code-stub-assembler.cc:362: max.Bind(Select(SmiLessThan(a, b), b, a)); On 2016/09/27 11:40:03, Igor Sheludko ...
4 years, 2 months ago (2016-09-27 13:35:46 UTC) #8
Igor Sheludko
lgtm
4 years, 2 months ago (2016-09-27 13:46:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372543002/20001
4 years, 2 months ago (2016-09-27 14:47:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-09-27 15:36:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372543002/20001
4 years, 2 months ago (2016-09-27 16:13:05 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 16:36:14 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 16:36:33 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f26c4d2d5510fab1a611547e03ff582032b86649
Cr-Commit-Position: refs/heads/master@{#39783}

Powered by Google App Engine