|
|
Created:
4 years, 2 months ago by jgruber Modified:
4 years, 2 months ago Reviewers:
Benedikt Meurer, Igor Sheludko CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[stubs] Add SmiMax and refactor SmiMin to use Select
SmiMax will be used in a follow-up commit.
BUG=
Committed: https://crrev.com/f26c4d2d5510fab1a611547e03ff582032b86649
Cr-Commit-Position: refs/heads/master@{#39783}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Address comments #
Created: 4 years, 2 months ago
Messages
Total messages: 21 (12 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jgruber@chromium.org changed reviewers: + bmeurer@chromium.org, ishell@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2372543002/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2372543002/diff/1/src/code-stub-assembler.cc#... src/code-stub-assembler.cc:362: max.Bind(Select(SmiLessThan(a, b), b, a)); I guess you can just return a Select node. https://codereview.chromium.org/2372543002/diff/1/src/code-stub-assembler.cc#... src/code-stub-assembler.cc:368: min.Bind(Select(SmiLessThan(a, b), a, b)); Same here.
https://codereview.chromium.org/2372543002/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2372543002/diff/1/src/code-stub-assembler.cc#... src/code-stub-assembler.cc:362: max.Bind(Select(SmiLessThan(a, b), b, a)); On 2016/09/27 11:40:03, Igor Sheludko wrote: > I guess you can just return a Select node. Done. https://codereview.chromium.org/2372543002/diff/1/src/code-stub-assembler.cc#... src/code-stub-assembler.cc:368: min.Bind(Select(SmiLessThan(a, b), a, b)); On 2016/09/27 11:40:03, Igor Sheludko wrote: > Same here. Done.
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by jgruber@chromium.org
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [stubs] Add SmiMax and refactor SmiMin to use Select SmiMax will be used in a follow-up commit. BUG= ========== to ========== [stubs] Add SmiMax and refactor SmiMin to use Select SmiMax will be used in a follow-up commit. BUG= Committed: https://crrev.com/f26c4d2d5510fab1a611547e03ff582032b86649 Cr-Commit-Position: refs/heads/master@{#39783} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f26c4d2d5510fab1a611547e03ff582032b86649 Cr-Commit-Position: refs/heads/master@{#39783} |