Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2372533002: [turbofan] Handle simplified ops in escape analysis. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Handle simplified ops in escape analysis. This adds handling of simplified ops without effect input to the escape status analysis. Such uses are treated as escaping for now until we add dedicated handling to the escape analysis reducer. R=bmeurer@chromium.org BUG=chromium:650170 Committed: https://crrev.com/ec0e9e6a400df0789b5269cd3c6b84b351d249e2 Cr-Commit-Position: refs/heads/master@{#39714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 2 months ago (2016-09-26 11:11:43 UTC) #1
Benedikt Meurer
Nice. LGTM.
4 years, 2 months ago (2016-09-26 11:18:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372533002/1
4 years, 2 months ago (2016-09-26 11:36:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 11:38:57 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 11:39:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec0e9e6a400df0789b5269cd3c6b84b351d249e2
Cr-Commit-Position: refs/heads/master@{#39714}

Powered by Google App Engine
This is Rietveld 408576698