Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 237253002: Fix bogus Object.isSealed check in some Array builtins. (Closed)

Created:
6 years, 8 months ago by Michael Starzinger
Modified:
6 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Fix bogus Object.isSealed check in some Array builtins. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M src/array.js View 2 chunks +0 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-builtinbust-4.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
This just removes two of the bogus occurrences of Object.isSealed checks in our built-ins. In ...
6 years, 8 months ago (2014-04-14 16:56:54 UTC) #1
mvstanton
LGTM.
6 years, 8 months ago (2014-04-15 08:06:07 UTC) #2
Michael Starzinger
6 years, 8 months ago (2014-04-15 08:25:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698