Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2372513005: Remove FilePathWatcher::PlatformDelegate::CancelOnMessageLoopThread(). (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FilePathWatcher::PlatformDelegate::CancelOnMessageLoopThread(). There is no reason to have this method in the PlatformDelegate interface it can simply be declared in subclasses that need it. BUG=650318 Committed: https://crrev.com/4430f9e5f415d06994bc12ba3fe2a8a46ac80482 Cr-Commit-Position: refs/heads/master@{#421583}

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -36 lines) Patch
M base/files/file_path_watcher.h View 1 chunk +0 lines, -5 lines 0 comments Download
M base/files/file_path_watcher.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M base/files/file_path_watcher_fsevents.h View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_kqueue.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_linux.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M base/files/file_path_watcher_mac.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M base/files/file_path_watcher_stub.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/files/file_path_watcher_win.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fdoray
PTAL
4 years, 2 months ago (2016-09-27 15:02:38 UTC) #8
dcheng
LGTM, I like code removal =)
4 years, 2 months ago (2016-09-27 23:31:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372513005/20001
4 years, 2 months ago (2016-09-28 17:30:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 18:30:50 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 18:34:13 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4430f9e5f415d06994bc12ba3fe2a8a46ac80482
Cr-Commit-Position: refs/heads/master@{#421583}

Powered by Google App Engine
This is Rietveld 408576698