Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2372513003: [es8] Remove syntactic tail calls support. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es8] Remove syntactic tail calls support. BUG=v8:4915 Committed: https://crrev.com/632e261a3a7acf47d0069696f6e94032b611f33f Cr-Commit-Position: refs/heads/master@{#39808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2051 lines) Patch
M src/bootstrapper.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/messages.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/parsing/parser-base.h View 24 chunks +0 lines, -128 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +0 lines, -1 line 0 comments Download
D test/message/syntactic-tail-call-generator.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/message/syntactic-tail-call-generator.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-binop-lhs.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/message/syntactic-tail-call-in-binop-lhs.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-binop-rhs.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/message/syntactic-tail-call-in-binop-rhs.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-comma.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/message/syntactic-tail-call-in-comma.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-extends.js View 1 chunk +0 lines, -10 lines 0 comments Download
D test/message/syntactic-tail-call-in-extends.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-for-in.js View 1 chunk +0 lines, -16 lines 0 comments Download
D test/message/syntactic-tail-call-in-for-in.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-for-of.js View 1 chunk +0 lines, -16 lines 0 comments Download
D test/message/syntactic-tail-call-in-for-of.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-logical-and.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/message/syntactic-tail-call-in-logical-and.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-logical-or.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/message/syntactic-tail-call-in-logical-or.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-subclass.js View 1 chunk +0 lines, -15 lines 0 comments Download
D test/message/syntactic-tail-call-in-subclass.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-try.js View 1 chunk +0 lines, -17 lines 0 comments Download
D test/message/syntactic-tail-call-in-try.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-try-catch-finally.js View 1 chunk +0 lines, -20 lines 0 comments Download
D test/message/syntactic-tail-call-in-try-catch-finally.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-in-try-try-catch-finally.js View 1 chunk +0 lines, -22 lines 0 comments Download
D test/message/syntactic-tail-call-in-try-try-catch-finally.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-inside-member-expr.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/message/syntactic-tail-call-inside-member-expr.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-of-eval.js View 1 chunk +0 lines, -9 lines 0 comments Download
D test/message/syntactic-tail-call-of-eval.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-of-identifier.js View 1 chunk +0 lines, -10 lines 0 comments Download
D test/message/syntactic-tail-call-of-identifier.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-of-new.js View 1 chunk +0 lines, -13 lines 0 comments Download
D test/message/syntactic-tail-call-of-new.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-sloppy.js View 1 chunk +0 lines, -9 lines 0 comments Download
D test/message/syntactic-tail-call-sloppy.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/syntactic-tail-call-without-return.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/message/syntactic-tail-call-without-return.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/mjsunit/es8/syntactic-tail-call.js View 1 chunk +0 lines, -604 lines 0 comments Download
D test/mjsunit/es8/syntactic-tail-call-parsing.js View 1 chunk +0 lines, -397 lines 0 comments Download
D test/mjsunit/es8/syntactic-tail-call-parsing-sloppy.js View 1 chunk +0 lines, -414 lines 0 comments Download
D test/mjsunit/es8/syntactic-tail-call-simple.js View 1 chunk +0 lines, -143 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Igor Sheludko
Hey Dan! PTAL
4 years, 2 months ago (2016-09-27 09:36:48 UTC) #7
Dan Ehrenberg
lgtm
4 years, 2 months ago (2016-09-27 14:40:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372513003/20001
4 years, 2 months ago (2016-09-28 07:43:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-09-28 08:25:33 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 08:25:54 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/632e261a3a7acf47d0069696f6e94032b611f33f
Cr-Commit-Position: refs/heads/master@{#39808}

Powered by Google App Engine
This is Rietveld 408576698