Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2372503002: MD WebUI: Change <cr-toolbar> clear button to not close the search field (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Change <cr-toolbar> clear button to not close the search field Clicking the clear seach button will now empty the search text and refocus the input field. This changes the behavior of the button to be in line with <cr-search-field>. BUG=633967 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/aee8764f43b8d50e7766d3de335086a655610100 Cr-Commit-Position: refs/heads/master@{#424906}

Patch Set 1 #

Patch Set 2 : Vulcanize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js View 3 chunks +14 lines, -4 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tsergeant
PTAL -- this was the old behavior from <cr-search-field>.
4 years, 2 months ago (2016-09-30 06:08:29 UTC) #3
Dan Beam
lgtm (sorry for the lag)
4 years, 2 months ago (2016-10-12 06:41:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372503002/20001
4 years, 2 months ago (2016-10-12 22:43:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 23:42:38 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 23:44:13 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aee8764f43b8d50e7766d3de335086a655610100
Cr-Commit-Position: refs/heads/master@{#424906}

Powered by Google App Engine
This is Rietveld 408576698