Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2372473002: Add global objects to constructor mapping of V8PerContextData (Closed)

Created:
4 years, 2 months ago by haraken
Modified:
4 years, 2 months ago
Reviewers:
iclelland, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add global objects to constructor mapping of V8PerContextData OriginTrials is going to assume that all DOM interfaces go through V8PerContextData::constructorForTypeSlowCase when the first wrapper is instantiated. Currently this does not happen in global objects. This CL fixes it. BUG= Committed: https://crrev.com/edc241d850804181a8c256ae705d1231a1aa3b1b Cr-Commit-Position: refs/heads/master@{#420939}

Patch Set 1 #

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (9 generated)
haraken
PTAL
4 years, 2 months ago (2016-09-26 06:15:39 UTC) #2
Yuki
Can we add a comment somewhere in order to say "all the interfaces must be ...
4 years, 2 months ago (2016-09-26 07:08:01 UTC) #4
haraken
On 2016/09/26 07:08:01, Yuki wrote: > Can we add a comment somewhere in order to ...
4 years, 2 months ago (2016-09-26 07:11:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372473002/10003
4 years, 2 months ago (2016-09-26 07:11:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147876)
4 years, 2 months ago (2016-09-26 09:42:33 UTC) #10
iclelland
lgtm
4 years, 2 months ago (2016-09-26 11:47:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372473002/10003
4 years, 2 months ago (2016-09-26 12:04:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147981)
4 years, 2 months ago (2016-09-26 14:33:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372473002/10003
4 years, 2 months ago (2016-09-26 14:41:45 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:10003)
4 years, 2 months ago (2016-09-26 18:30:00 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:31:37 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/edc241d850804181a8c256ae705d1231a1aa3b1b
Cr-Commit-Position: refs/heads/master@{#420939}

Powered by Google App Engine
This is Rietveld 408576698