Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2372433003: Replace twitter with pinterest in v8.mobile_infinite_scroll_tbmv2. (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 2 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace twitter with pinterest in v8.mobile_infinite_scroll_tbmv2. The twitter website has small V8 heap (6MB) and doesn't do any major GC. The pinterest website has larger V8 heap (35MB) and does 6 major GCs. So for GC team pinterest is more interesting than twitter. NOTE for perf sheriffs: Regressions and improvements are expected in mobile_infinite_scroll_tbmv2. Committed: https://crrev.com/bdaa23ddfe686d134e5fa4f55b68910814fa8b03 Cr-Commit-Position: refs/heads/master@{#421490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M tools/perf/page_sets/data/mobile_infinite_scroll.json View 1 chunk +9 lines, -6 lines 0 comments Download
A tools/perf/page_sets/data/mobile_infinite_scroll_001.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/mobile_infinite_scroll_cases.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
ulan
Ned, could you please take a look?
4 years, 2 months ago (2016-09-26 16:17:08 UTC) #2
nednguyen
lgtm I like how you find out about these & replacing existing stories instead of ...
4 years, 2 months ago (2016-09-26 16:19:25 UTC) #4
ulan
On 2016/09/26 16:19:25, nednguyen wrote: > lgtm > > I like how you find out ...
4 years, 2 months ago (2016-09-26 16:28:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372433003/1
4 years, 2 months ago (2016-09-26 16:29:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286204)
4 years, 2 months ago (2016-09-26 18:00:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372433003/1
4 years, 2 months ago (2016-09-28 09:15:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 10:12:27 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 10:15:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdaa23ddfe686d134e5fa4f55b68910814fa8b03
Cr-Commit-Position: refs/heads/master@{#421490}

Powered by Google App Engine
This is Rietveld 408576698