Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 237243003: Refactor ParseFunctionLiteral. (Closed)

Created:
6 years, 8 months ago by marja
Modified:
6 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Refactor ParseFunctionLiteral. It was a pretty monstrous 500 line function. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20752

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -129 lines) Patch
M src/parser.h View 1 1 chunk +17 lines, -2 lines 0 comments Download
M src/parser.cc View 1 4 chunks +151 lines, -127 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ptal
6 years, 8 months ago (2014-04-14 16:34:18 UTC) #1
Michael Starzinger
LGTM.
6 years, 8 months ago (2014-04-15 08:14:41 UTC) #2
marja
6 years, 8 months ago (2014-04-15 08:29:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20752 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698