Made CFieldTree::Node a class.

Made CFieldTree::Node a class.

Committed: https://pdfium.googlesource.com/pdfium/+/3b440ac32e3b9abaf6d013225b7a31a976b48759

[Lei Zhang, 2016-09-27 23:39:24]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 23:39:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-27 23:47:24]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 23:47:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-27 23:52:19]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[commit-bot: I haz the power, 2016-09-27 23:59:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 23:59:04]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-28 00:10:01]

https://codereview.chromium.org/2372423002/diff/20001/core/fpdfdoc/cpdf_inter...
File core/fpdfdoc/cpdf_interform.cpp (right):

https://codereview.chromium.org/2372423002/diff/20001/core/fpdfdoc/cpdf_inter...
core/fpdfdoc/cpdf_interform.cpp:551: Node* GetChildAt(size_t i) { return
children_[i]; }
nit: is this a const method?

https://codereview.chromium.org/2372423002/diff/20001/core/fpdfdoc/cpdf_inter...
core/fpdfdoc/cpdf_interform.cpp:585: void set_field_ptr(CPDF_FormField* field) {
field_ptr_ = field; }
nit: not sure time to go full chromium naming.

SetFormField();
GetFormField();
GetShortName();

https://codereview.chromium.org/2372423002/diff/20001/core/fpdfdoc/cpdf_inter...
core/fpdfdoc/cpdf_interform.cpp:586: CPDF_FormField* field() { return
field_ptr_; }
nit: const method?

https://codereview.chromium.org/2372423002/diff/20001/core/fpdfdoc/cpdf_inter...
core/fpdfdoc/cpdf_interform.cpp:590: std::vector<Node*> children_;
nit: not sure now is the time to go full chromium naming

m_Children;
m_ShortName;
m_pFormField;

[Lei Zhang, 2016-09-28 00:22:49]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[Lei Zhang, 2016-09-28 00:22:55]

https://codereview.chromium.org/2372423002/diff/20001/core/fpdfdoc/cpdf_inter...
File core/fpdfdoc/cpdf_interform.cpp (right):

https://codereview.chromium.org/2372423002/diff/20001/core/fpdfdoc/cpdf_inter...
core/fpdfdoc/cpdf_interform.cpp:551: Node* GetChildAt(size_t i) { return
children_[i]; }
On 2016/09/28 00:10:01, Tom Sepez wrote:
> nit: is this a const method?

Added a const version.

https://codereview.chromium.org/2372423002/diff/20001/core/fpdfdoc/cpdf_inter...
core/fpdfdoc/cpdf_interform.cpp:585: void set_field_ptr(CPDF_FormField* field) {
field_ptr_ = field; }
On 2016/09/28 00:10:01, Tom Sepez wrote:
> nit: not sure time to go full chromium naming.
> 
> SetFormField();
> GetFormField();
> GetShortName();

Done.

https://codereview.chromium.org/2372423002/diff/20001/core/fpdfdoc/cpdf_inter...
core/fpdfdoc/cpdf_interform.cpp:586: CPDF_FormField* field() { return
field_ptr_; }
On 2016/09/28 00:10:01, Tom Sepez wrote:
> nit: const method?

Added const version.

https://codereview.chromium.org/2372423002/diff/20001/core/fpdfdoc/cpdf_inter...
core/fpdfdoc/cpdf_interform.cpp:590: std::vector<Node*> children_;
On 2016/09/28 00:10:01, Tom Sepez wrote:
> nit: not sure now is the time to go full chromium naming
> 
> m_Children;
> m_ShortName;
> m_pFormField;

Oh, they started out looking like chromium naming and I've been switching repos
all day long.

[commit-bot: I haz the power, 2016-09-28 00:22:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 00:32:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 00:33:00]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-28 07:31:03]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 07:31:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 07:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 07:31:09]

Dry run: CLs for remote refs other than refs/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[Tom Sepez, 2016-09-28 16:42:57]

lgtm

[Lei Zhang, 2016-09-28 17:47:12]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-09-28 17:47:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2372423002/#ps80001
(title: "upload again")

[commit-bot: I haz the power, 2016-09-28 17:47:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:57:20]

Description was changed from

==========
Made CFieldTree::Node a class.
==========

to

==========
Made CFieldTree::Node a class.

Committed:
https://pdfium.googlesource.com/pdfium/+/3b440ac32e3b9abaf6d013225b7a31a976b4...
==========

[commit-bot: I haz the power, 2016-09-28 17:57:21]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/3b440ac32e3b9abaf6d013225b7a31a976b4...