Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2372393002: Reland of Android: Trigger tab placeholder update when activity is paused (Closed)

Created:
4 years, 2 months ago by no sievers
Modified:
4 years, 2 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, perezju
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Android: Trigger tab placeholder update when activity is paused (patchset #1 id:1 of https://codereview.chromium.org/2306623002/ ) Reason for reland (revert-of-revert): Now that https://codereview.chromium.org/2336043004/ has landed, we will free GL context-related ashmem after the readback and when the app goes to the background. Original issue's description: > Revert of Android: Trigger tab placeholder update when activity is paused (patchset #3 id:40001 of https://codereview.chromium.org/2186453004/ ) > > Reason for revert: > Seeing lots of memory regression since this landed. Bisects point to this CL with high confidence. See crbug.com/641962. > > Original issue's description: > > Android: Trigger tab placeholder update when activity is paused > > > > This makes sure we have a placeholder bitmap when we resume > > and don't have a frame from the renderer yet. > > > > BUG=636630 > > > > Committed: https://crrev.com/0a1f48d5cb6a5d263f85bc5322912b7f703c40ac > > Cr-Commit-Position: refs/heads/master@{#414822} > > TBR=dtrainor@chromium.org,sievers@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=636630, 641962 > > Committed: https://crrev.com/be54d2fa0b7a766b0391de082eebeeee53888397 > Cr-Commit-Position: refs/heads/master@{#415990} TBR=dtrainor@chromium.org,primiano@chromium.org,mustaq@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636630, 641962 Committed: https://crrev.com/5d34220f9b827cfd514e03ba6215286f2467f29d Cr-Commit-Position: refs/heads/master@{#421390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
no sievers
Created Reland of Android: Trigger tab placeholder update when activity is paused
4 years, 2 months ago (2016-09-27 23:16:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372393002/1
4 years, 2 months ago (2016-09-27 23:18:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 23:59:58 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 00:01:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d34220f9b827cfd514e03ba6215286f2467f29d
Cr-Commit-Position: refs/heads/master@{#421390}

Powered by Google App Engine
This is Rietveld 408576698