Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Issue 237233002: Move 'embeds' / 'plugins' attributes from HTMLDocument to Document (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive, abarth-chromium
Visibility:
Public.

Description

Move 'embeds' / 'plugins' attributes from HTMLDocument to Document Move 'embeds' / 'plugins' attributes from HTMLDocument to Document to comply with the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#dom-document-embeds This behavior is consistent with IE11. However, Firefox 28 still exposes those attributes on HTMLDocument. BUG=362955 TEST=fast/dom/Document/embeds-non-html.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171682

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Attempt to fix Windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
A + LayoutTests/fast/dom/Document/embeds-non-html.html View 1 1 chunk +5 lines, -4 lines 0 comments Download
A + LayoutTests/fast/dom/Document/embeds-non-html-expected.txt View 1 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Inactive
6 years, 8 months ago (2014-04-14 17:33:08 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 8 months ago (2014-04-14 18:01:09 UTC) #2
tkent
lgtm
6 years, 8 months ago (2014-04-15 05:12:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/237233002/1
6 years, 8 months ago (2014-04-15 05:12:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 05:23:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-15 05:23:38 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-15 12:03:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/237233002/1
6 years, 8 months ago (2014-04-15 12:03:38 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 12:03:43 UTC) #9
commit-bot: I haz the power
Failed to apply patch for Source/core/html/HTMLDocument.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-15 12:03:44 UTC) #10
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-15 14:08:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/237233002/20001
6 years, 8 months ago (2014-04-15 14:08:23 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 15:17:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-15 15:17:12 UTC) #14
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-15 15:27:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/237233002/20001
6 years, 8 months ago (2014-04-15 15:28:18 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 16:37:55 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-15 16:37:55 UTC) #18
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-15 18:55:40 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/237233002/40001
6 years, 8 months ago (2014-04-15 18:55:52 UTC) #20
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 19:43:04 UTC) #21
Message was sent while issue was closed.
Change committed as 171682

Powered by Google App Engine
This is Rietveld 408576698