Add pageable data widget

appengine/swarming/elements/res/imp/botpage/bot-page.html

 <!--
   Copyright 2016 The LUCI Authors. All rights reserved.
   Use of this source code is governed under the Apache License, Version 2.0
   that can be found in the LICENSE file.
 
   This in an HTML Import-able file that contains the definition
   of the following elements:
 
     <bot-page>
 
@@ skipping 17 matching lines @@
 <link rel="import" href="/res/imp/bower_components/iron-icon/iron-icon.html">
 <link rel="import" href="/res/imp/bower_components/iron-icons/iron-icons.html">
 <link rel="import" href="/res/imp/bower_components/paper-button/paper-button.html">
 <link rel="import" href="/res/imp/bower_components/paper-checkbox/paper-checkbox.html">
 <link rel="import" href="/res/imp/bower_components/paper-dialog/paper-dialog.html">
 <link rel="import" href="/res/imp/bower_components/paper-input/paper-input.html">
 <link rel="import" href="/res/imp/bower_components/paper-tabs/paper-tabs.html">
 <link rel="import" href="/res/imp/bower_components/polymer/polymer.html">
 
 <link rel="import" href="/res/imp/common/error-toast.html">
+<link rel="import" href="/res/imp/common/pageable-data.html">
 <link rel="import" href="/res/imp/common/single-page-style.html">
 <link rel="import" href="/res/imp/common/swarming-app.html">
 <link rel="import" href="/res/imp/common/task-behavior.html">
 <link rel="import" href="/res/imp/common/url-param.html">
 
 <link rel="import" href="bot-page-data.html">
 <link rel="import" href="bot-page-shared-behavior.html">
 
 
 <dom-module id="bot-page">
@@ skipping 40 matching lines @@
     <url-param name="show_state"
       value="{{_show_state}}">
     </url-param>
 
     <swarming-app
       client_id="[[client_id]]"
       auth_headers="{{_auth_headers}}"
       permissions="{{_permissions}}"
       signed_in="{{_signed_in}}"
 
-      busy="[[_busy]]"
+      busy="[[_or(_busy1,_busy2,_busy3)]]"
       name="Swarming Bot Page">
 
       <h2 hidden$="[[_signed_in]]">You must sign in to see anything useful.</h2>
 
       <div hidden$="[[_not(_signed_in)]]">
 
         <bot-page-data
           id="data"
           auth_headers="[[_auth_headers]]"
           bot_id="[[bot_id]]"
 
           bot="{{_bot}}"
-          busy="{{_busy}}"
+          busy="{{_busy1}}"
           events="{{_events}}"
-          tasks="{{_tasks}}">
+          tasks="{{_tasks}}"
+          on-reload="_clearAndReload">
         </bot-page-data>
 
         <div class="header horizontal layout">
           <paper-input class="id_input" label="Bot id" value="{{bot_id}}"></paper-input>
           <button on-click="_refresh">
             <iron-icon class="refresh" icon="icons:refresh"></iron-icon>
           </button>
         </div>
 
         <div>
@@ skipping 135 matching lines @@
             <thead>
               <tr>
                 <th>Message</th>
                 <th>Type</th>
                 <th>Timestamp</th>
                 <th>Task ID</th>
                 <th>Version</th>
               </tr>
             </thead>
             <tbody>
-              <template is="dom-repeat" items="{{_eventList(_events,_show_all)}}" as="event">
+              <template is="dom-repeat" items="{{_eventList(_show_all,_events.*)}}" as="event">
                 <tr>
                   <td class="message">[[event.message]]</a></td>
                   <td>[[event.event_type]]</td>
                   <td>[[event.human_ts]]</td>
                   <td><a target="_blank" href$="[[_taskLink(event.task_id)]]">[[event.task_id]]</a></td>
                   <td>
                     <a target="_blank" href$="[[_luciLink(event.version)]]">[[_shorten(event.version,'8')]]</a>
                   </td>
                 </tr>
               </template>
             </tbody>
           </table>
         </template>
+        <pageable-data
+          id="page_tasks"
+          hidden$="[[_truthy(_selected)]]"

[stephana, 2016/09/28 13:25:23]

who does 'selected' alone not work here ? 

[kjlubick, 2016/09/28 13:50:36]

I'm not entirely sure, but it seems that when _selected is the string "0", i.e.
show tasks, hidden$= evaluates to true.  This hack seems to make it properly be
false.

[stephana, 2016/09/28 15:45:33]

if _selected is string "0", _truthy will return true. And in this scenario
_selected should always an integer, so it can be used directly. 

+          busy="{{_busy2}}"
+          label="Show more tasks"
+          output="{{_tasks}}"
+          parse="[[_parseTasks]]">
+        </pageable-data>
+        <pageable-data
+          id="page_events"
+          hidden$="[[_not(_selected)]]"
+          busy="{{_busy3}}"
+          label="Show more events"
+          output="{{_events}}"
+          parse="[[_parseEvents]]">
+        </pageable-data>
       </div>
     </swarming-app>
 
     <paper-dialog id="prompt" modal on-iron-overlay-closed="_promptClosed">
       <h2>Are you sure?</h2>
       <div>Are you sure you want to [[_dialogPrompt]]?</div>
       <div class="buttons">
         <paper-button dialog-dismiss autofocus>No</paper-button>
         <paper-button dialog-confirm>Yes</paper-button>
       </div>
@@ skipping 15 matching lines @@
       properties: {
         bot_id: {
           type: String,
         },
         client_id: {
           type: String,
         },
 
         _auth_headers: {
           type: Object,
+          observer: "_reload",
         },
         _bot: {
           type: Object,
         },
         _dialogPrompt: {
           type: String,
           value: "",
         },
         _selected: {
           type: Number,
         },
         _show_all: {
           type: Boolean,
         },
         _show_state: {
           type: Boolean,
+        },
+
+        _parseEvents: {

[stephana, 2016/09/28 13:25:23]

This don't need to be defined in properties. Why can't you just define them as
functions on the element below. 

[kjlubick, 2016/09/28 13:50:36]

I tried defining the functions below, but Polymer didn't pass them as I expected
into pageable-data.

[stephana, 2016/09/28 15:45:33]

Acknowledged.

+          type: Function,
+          value: function() {
+            return this.$.data.parseEvents.bind(this);
+          }
+        },
+        _parseTasks: {
+          type: Function,
+          value: function() {
+            return this.$.data.parseTasks.bind(this);
+          }
         }
       },
 
       _canCancel: function(bot, permissions) {
         return bot && bot.task_id && permissions.cancel_task;
       },
 
       _canDelete: function(bot, permissions) {
         return bot && bot.is_dead && permissions.delete_bot;
       },
 
       _canShutdown: function(bot, permissions){
         return bot && !bot.is_dead && permissions.terminate_bot;
       },
 
+      _clearAndReload: function(botID) {
+        this.$.page_tasks.clear();
+        this.$.page_events.clear();
+        this._reload();
+      },
+
       _concat: function(arr) {
         if (!arr) {
           return "";
         }
         return arr.join(" | ");
       },
 
       _deleteBot: function() {
         swarming.postWithToast("/_ah/api/swarming/v1/bot/"+this.bot_id+"/delete",
           "Deleting "+this.bot_id, this._auth_headers);
       },
 
-      _eventList(events, showAll) {
-        if (!events) {
+      _eventList(showAll) {
+        if (!this._events) {
           return [];
         }
-        return events.filter(function(e){
+        return this._events.filter(function(e){
           return showAll || e.message;
         });
       },
 
       _isDead(bot){
         if (bot && bot.is_dead) {
           return "dead";
         }
         return "";
       },
@@ skipping 48 matching lines @@
           }
           return msg || "True";
         }
         return "";
       },
 
       _refresh: function() {
         this.$.data.request();
       },
 
+      _reload: function() {
+        if (!this._auth_headers) {
+          return;
+        }
+        var baseUrl = "/_ah/api/swarming/v1/bot/"+this.bot_id;
+        // We limit the fields on these two queries to make them faster.
+        this.$.page_tasks.load(baseUrl + "/tasks?fields=cursor%2Citems(abandoned_ts%2Cbot_version%2Ccompleted_ts%2Cduration%2Cexit_code%2Cfailure%2Cinternal_failure%2Cmodified_ts%2Cname%2Cstarted_ts%2Cstate%2Ctask_id%2Ctry_number)",
+          this._auth_headers, 30);
+        this.$.page_events.load(baseUrl + "/events?fields=cursor%2Citems(event_type%2Cmessage%2Cquarantined%2Ctask_id%2Cts%2Cversion)",
+          this._auth_headers, 50);
+      },
+
       _shorten: function(str, length) {
         if (!str || ! length) {
           return "";
         }
         return str.substring(0, length);
       },
 
       _shutdownBot: function() {
         swarming.postWithToast("/_ah/api/swarming/v1/bot/"+this.bot_id+"/terminate",
           "Shutting down "+this.bot_id, this._auth_headers);
@@ skipping 14 matching lines @@
       },
 
       _toggleState: function() {
         this.set("_show_state", !this._show_state);
       }
 
     });
   })();
   </script>
 </dom-module>