Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2372293002: Removed navigator.pointerEnabled API. (Closed)

Created:
4 years, 2 months ago by mustaq
Modified:
4 years, 2 months ago
Reviewers:
dtapuska, Rick Byers
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed navigator.pointerEnabled API. The deprecated API was added temporarily only to estimate its usage. This CL also removes unused counters for Pointer Events. BUG=631897 Committed: https://crrev.com/dd33bdb2ed843cdf6679dd27a5802136c69de0a4 Cr-Commit-Position: refs/heads/master@{#421526}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reverted the xml changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 chunk +4 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/events/NavigatorEvents.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/NavigatorEvents.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/NavigatorEvents.idl View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
mustaq
ptal
4 years, 2 months ago (2016-09-27 18:29:51 UTC) #4
dtapuska
On 2016/09/27 18:29:51, mustaq wrote: > ptal lgtm % I presume we got enough data ...
4 years, 2 months ago (2016-09-27 18:37:43 UTC) #5
mustaq
On 2016/09/27 18:37:43, dtapuska wrote: > On 2016/09/27 18:29:51, mustaq wrote: > > ptal > ...
4 years, 2 months ago (2016-09-27 20:07:31 UTC) #6
Rick Byers
On 2016/09/27 20:07:31, mustaq wrote: > On 2016/09/27 18:37:43, dtapuska wrote: > > On 2016/09/27 ...
4 years, 2 months ago (2016-09-27 20:38:06 UTC) #9
mustaq
On current Chrome-Win-beta (54.0.2840.34), ~0.53% of page visits access pointerEnabled, which is less than dev ...
4 years, 2 months ago (2016-09-27 21:04:09 UTC) #10
mustaq
On 2016/09/27 21:04:09, mustaq wrote: > On current Chrome-Win-beta (54.0.2840.34), ~0.53% of page visits access ...
4 years, 2 months ago (2016-09-28 13:56:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372293002/20001
4 years, 2 months ago (2016-09-28 13:57:13 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 15:37:52 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 15:46:49 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd33bdb2ed843cdf6679dd27a5802136c69de0a4
Cr-Commit-Position: refs/heads/master@{#421526}

Powered by Google App Engine
This is Rietveld 408576698