Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2372283002: [Cast] Make decoder_config.h usable without decoder_config_adapter.cc (Closed)

Created:
4 years, 2 months ago by servolk
Modified:
4 years, 2 months ago
Reviewers:
halliwell
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, gfhuang+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast] Make decoder_config.h usable without decoder_config_adapter.cc This is necessary to fix build break for OEMs that include decoder_config.h, but don't use decoder_config_adapter.cc Committed: https://crrev.com/8ee4d2ad5fa99f247509e0967d9668f3bcf0f7b5 Cr-Commit-Position: refs/heads/master@{#421316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chromecast/media/cma/base/decoder_config_adapter.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chromecast/public/media/decoder_config.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
servolk
4 years, 2 months ago (2016-09-27 17:54:59 UTC) #5
halliwell
On 2016/09/27 17:54:59, servolk wrote: lgtm
4 years, 2 months ago (2016-09-27 19:07:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372283002/1
4 years, 2 months ago (2016-09-27 20:14:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 20:19:35 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 20:21:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ee4d2ad5fa99f247509e0967d9668f3bcf0f7b5
Cr-Commit-Position: refs/heads/master@{#421316}

Powered by Google App Engine
This is Rietveld 408576698