Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2372263002: De-virtualize many CFFL_InteractiveFormFiller methods. (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

De-virtualize many CFFL_InteractiveFormFiller methods. Apart from the IPWL_Filler_Notify overrides, none of these are overriden because there are no subclasses. Committed: https://pdfium.googlesource.com/pdfium/+/5060b2e37b82a2e2907e11685ed2998d06d8b452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -59 lines) Patch
M fpdfsdk/formfiller/cffl_interactiveformfiller.h View 1 chunk +54 lines, -59 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Lei, for review.
4 years, 2 months ago (2016-09-27 17:08:13 UTC) #4
Lei Zhang
lgtm
4 years, 2 months ago (2016-09-27 17:10:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372263002/1
4 years, 2 months ago (2016-09-27 20:34:16 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 21:06:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5060b2e37b82a2e2907e11685ed2998d06d8...

Powered by Google App Engine
This is Rietveld 408576698