Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2372243003: Remove a couple desktop infobar png assets. (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a couple desktop infobar png assets. BUG=648281 TBR=oshima@chromium.org,rdevlin.cronin@chromium.org Committed: https://crrev.com/d982acf0da90234b529418522191095473e016a2 Cr-Commit-Position: refs/heads/master@{#421855}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : remove mac macro #

Messages

Total messages: 24 (15 generated)
Evan Stade
4 years, 2 months ago (2016-09-28 22:50:30 UTC) #7
oshima
c/a/theme lgtm
4 years, 2 months ago (2016-09-28 23:11:07 UTC) #9
Peter Kasting
LGTM https://codereview.chromium.org/2372243003/diff/20001/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc File chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc (right): https://codereview.chromium.org/2372243003/diff/20001/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc#newcode112 chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc:112: #if defined(OS_MACOSX) Shouldn't we rip out this #if?
4 years, 2 months ago (2016-09-29 04:20:01 UTC) #12
Evan Stade
https://codereview.chromium.org/2372243003/diff/20001/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc File chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc (right): https://codereview.chromium.org/2372243003/diff/20001/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc#newcode112 chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc:112: #if defined(OS_MACOSX) On 2016/09/29 04:20:01, Peter Kasting (busy Sep ...
4 years, 2 months ago (2016-09-29 16:29:44 UTC) #13
Evan Stade
tbr oshima, devlin for mechanical changes
4 years, 2 months ago (2016-09-29 16:35:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372243003/40001
4 years, 2 months ago (2016-09-29 16:36:10 UTC) #19
Devlin
extensions lgtm
4 years, 2 months ago (2016-09-29 16:45:50 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-29 17:13:08 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 17:16:08 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d982acf0da90234b529418522191095473e016a2
Cr-Commit-Position: refs/heads/master@{#421855}

Powered by Google App Engine
This is Rietveld 408576698