Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2372193002: [CustomTabsBenchmark] Support prerendering mode (Closed)

Created:
4 years, 2 months ago by droger
Modified:
4 years, 2 months ago
Reviewers:
Benoit L
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CustomTabsBenchmark] Support prerendering mode This CL allows to set the prerendering mode to disabled, enabled, or prefetch. This replaces the old 'no_prerendering' boolean. The prerendering mode is passed to the java application (changing its type from a boolean to a string), and to Chrome as a command line switch. Committed: https://crrev.com/51d7f96fac92e6c0707fb49b0476beb37c0ddde4 Cr-Commit-Position: refs/heads/master@{#421487}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : Change no_prerendering from bool #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -25 lines) Patch
M tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java View 1 2 6 chunks +22 lines, -11 lines 0 comments Download
M tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py View 1 2 3 9 chunks +42 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
droger
4 years, 2 months ago (2016-09-27 14:06:20 UTC) #3
Benoit L
On 2016/09/27 14:06:20, droger wrote: lgtm
4 years, 2 months ago (2016-09-27 14:25:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372193002/100001
4 years, 2 months ago (2016-09-28 09:45:48 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 2 months ago (2016-09-28 09:54:33 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 09:56:42 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/51d7f96fac92e6c0707fb49b0476beb37c0ddde4
Cr-Commit-Position: refs/heads/master@{#421487}

Powered by Google App Engine
This is Rietveld 408576698