Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2372123002: [Bindings] Do not depend on IDL files to detect target component (Closed)

Created:
4 years, 2 months ago by peria
Modified:
4 years, 2 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, Dirk Pranke, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not depend on IDL files to detect target component BUG=650150 Committed: https://crrev.com/308274de40f7f475686a32da81e1be0db1dd422a Cr-Commit-Position: refs/heads/master@{#421143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M third_party/WebKit/Source/bindings/scripts/idl_compiler.py View 5 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
peria
PTL
4 years, 2 months ago (2016-09-27 05:48:14 UTC) #3
bashi
lgtm
4 years, 2 months ago (2016-09-27 05:52:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372123002/1
4 years, 2 months ago (2016-09-27 05:53:35 UTC) #6
haraken
LGTM
4 years, 2 months ago (2016-09-27 07:23:54 UTC) #7
Yuki
LGTM.
4 years, 2 months ago (2016-09-27 07:35:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 07:57:10 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 07:58:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/308274de40f7f475686a32da81e1be0db1dd422a
Cr-Commit-Position: refs/heads/master@{#421143}

Powered by Google App Engine
This is Rietveld 408576698