src/builtins/x64/builtins-x64.cc - Issue 2372113004: [turbofan] JSGenericLowering mostly uses builtins instead of code stubs now

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/x64/builtins-x64.cc

Issue 2372113004: [turbofan] JSGenericLowering mostly uses builtins instead of code stubs now (Closed)

Patch Set: Ross' comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/x64/builtins-x64.cc

diff --git a/src/builtins/x64/builtins-x64.cc b/src/builtins/x64/builtins-x64.cc

index beae2d29c36bdbcb3de0fd3401ce678974b517b3..fb1c5982d3360c991fe2e8db5267fef3de6309d4 100644

--- a/src/builtins/x64/builtins-x64.cc

+++ b/src/builtins/x64/builtins-x64.cc

@@ -2583,8 +2583,8 @@ void Builtins::Generate_CallFunction(MacroAssembler* masm,

__ Push(rdi);

__ movp(rax, rcx);

__ Push(rsi);

- ToObjectStub stub(masm->isolate());

- __ CallStub(&stub);

+ __ Call(masm->isolate()->builtins()->ToObject(),

+ RelocInfo::CODE_TARGET);

__ Pop(rsi);

__ movp(rcx, rax);

__ Pop(rdi);

« no previous file with comments | « src/builtins/s390/builtins-s390.cc ('k') | src/builtins/x87/builtins-x87.cc » ('j') | no next file with comments »