Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2372113004: [turbofan] JSGenericLowering mostly uses builtins instead of code stubs now (Closed)
Patch Set: fixed another bug: switched arguments in Interpreter::DoTestIn Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index 6adb62fc166b3880ad364d9225920e457d2a2918..5f062d9649a6586aa003d603b9fbe774b4b51914 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -5261,11 +5261,10 @@ void HOptimizedGraphBuilder::BuildForInBody(ForInStatement* stmt,
}
set_current_block(if_slow);
{
- ForInFilterStub stub(isolate());
+ Callable callable = CodeFactory::ForInFilter(isolate());
HValue* values[] = {context(), key, enumerable};
- HConstant* stub_value = Add<HConstant>(stub.GetCode());
- Push(Add<HCallWithDescriptor>(stub_value, 0,
- stub.GetCallInterfaceDescriptor(),
+ HConstant* stub_value = Add<HConstant>(callable.code());
+ Push(Add<HCallWithDescriptor>(stub_value, 0, callable.descriptor(),
ArrayVector(values)));
Add<HSimulate>(stmt->FilterId());
FinishCurrentBlock(New<HCompareObjectEqAndBranch>(

Powered by Google App Engine
This is Rietveld 408576698