Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/crankshaft/hydrogen.cc

Issue 2372113004: [turbofan] JSGenericLowering mostly uses builtins instead of code stubs now (Closed)
Patch Set: Ross' comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen.h" 5 #include "src/crankshaft/hydrogen.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/allocation-site-scopes.h" 10 #include "src/allocation-site-scopes.h"
(...skipping 5243 matching lines...) Expand 10 before | Expand all | Expand 10 after
5254 FinishCurrentBlock( 5254 FinishCurrentBlock(
5255 New<HCompareObjectEqAndBranch>(enumerable_map, type, if_fast, if_slow)); 5255 New<HCompareObjectEqAndBranch>(enumerable_map, type, if_fast, if_slow));
5256 set_current_block(if_fast); 5256 set_current_block(if_fast);
5257 { 5257 {
5258 // The enum cache for enumerable is still valid, no need to check key. 5258 // The enum cache for enumerable is still valid, no need to check key.
5259 Push(key); 5259 Push(key);
5260 Goto(if_join); 5260 Goto(if_join);
5261 } 5261 }
5262 set_current_block(if_slow); 5262 set_current_block(if_slow);
5263 { 5263 {
5264 ForInFilterStub stub(isolate()); 5264 Callable callable = CodeFactory::ForInFilter(isolate());
5265 HValue* values[] = {context(), key, enumerable}; 5265 HValue* values[] = {context(), key, enumerable};
5266 HConstant* stub_value = Add<HConstant>(stub.GetCode()); 5266 HConstant* stub_value = Add<HConstant>(callable.code());
5267 Push(Add<HCallWithDescriptor>(stub_value, 0, 5267 Push(Add<HCallWithDescriptor>(stub_value, 0, callable.descriptor(),
5268 stub.GetCallInterfaceDescriptor(),
5269 ArrayVector(values))); 5268 ArrayVector(values)));
5270 Add<HSimulate>(stmt->FilterId()); 5269 Add<HSimulate>(stmt->FilterId());
5271 FinishCurrentBlock(New<HCompareObjectEqAndBranch>( 5270 FinishCurrentBlock(New<HCompareObjectEqAndBranch>(
5272 Top(), graph()->GetConstantUndefined(), if_slow_skip, if_slow_pass)); 5271 Top(), graph()->GetConstantUndefined(), if_slow_skip, if_slow_pass));
5273 } 5272 }
5274 set_current_block(if_slow_pass); 5273 set_current_block(if_slow_pass);
5275 { Goto(if_join); } 5274 { Goto(if_join); }
5276 set_current_block(if_slow_skip); 5275 set_current_block(if_slow_skip);
5277 { 5276 {
5278 // The key is no longer valid for enumerable, skip it. 5277 // The key is no longer valid for enumerable, skip it.
(...skipping 8005 matching lines...) Expand 10 before | Expand all | Expand 10 after
13284 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13283 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13285 } 13284 }
13286 13285
13287 #ifdef DEBUG 13286 #ifdef DEBUG
13288 graph_->Verify(false); // No full verify. 13287 graph_->Verify(false); // No full verify.
13289 #endif 13288 #endif
13290 } 13289 }
13291 13290
13292 } // namespace internal 13291 } // namespace internal
13293 } // namespace v8 13292 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698