[tracing] Prevent tabbing to some hidden controls

[tracing] Prevent tabbing to some hidden controls

In the 'Record a new trace...' view you can tab to some controls even
when they're hidden behind the 'Edit categories' toggle. To prevent this
we add "display: none" to the container of those controls when they
should be hidden.

BUG=chromium:629480
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f332dd6dd55d4754ecf770f5edc7cc606b13a161

[hjd, 2016-09-27 15:03:10]

hjd@chromium.org changed reviewers:
+ petrcermak@chromium.org, primiano@chromium.org

[hjd, 2016-09-27 15:03:11]

ptal, thanks! :)

[fmeawad, 2016-09-27 15:04:37]

fmeawad@chromium.org changed reviewers:
+ fmeawad@chromium.org

[fmeawad, 2016-09-27 15:04:37]

lgtm

[petrcermak, 2016-09-27 15:25:49]

LGTM with 1 comment and please change "BUG=629480" to "BUG=chromium:629480".

Thanks,
Petr

https://codereview.chromium.org/2372103003/diff/1/tracing/tracing/ui/extras/a...
File tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html
(right):

https://codereview.chromium.org/2372103003/diff/1/tracing/tracing/ui/extras/a...
tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html:32:
display: gone;
don't you mean "none"???

[hjd, 2016-09-27 20:42:30]

Description was changed from

==========
[tracing] Prevent tabbing to some hidden controls

In the 'Record a new trace...' view you can tab to some controls even
when they're hidden behind the 'Edit categories' toggle. To prevent this
we add "display: gone" to the container of those controls when they
should be hidden.

BUG=629480
==========

to

==========
[tracing] Prevent tabbing to some hidden controls

In the 'Record a new trace...' view you can tab to some controls even
when they're hidden behind the 'Edit categories' toggle. To prevent this
we add "display: none" to the container of those controls when they
should be hidden.

BUG=chromium:629480
==========

[hjd, 2016-09-27 20:45:43]

On 2016/09/27 15:25:49, petrcermak wrote:
> LGTM with 1 comment and please change "BUG=629480" to "BUG=chromium:629480".

Thanks :)

> Thanks,
> Petr
> 
>
https://codereview.chromium.org/2372103003/diff/1/tracing/tracing/ui/extras/a...
> File tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html
> (right):
> 
>
https://codereview.chromium.org/2372103003/diff/1/tracing/tracing/ui/extras/a...
> tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html:32:
> display: gone;
> don't you mean "none"???

oops... my Android is showing, thanks!

[hjd, 2016-09-28 09:48:09]

The CQ bit was checked by hjd@chromium.org

[hjd, 2016-09-28 09:48:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmeawad@chromium.org, petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/2372103003/#ps20001
(title: "s/android/chromium/")

[commit-bot: I haz the power, 2016-09-28 09:48:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 10:50:55]

Description was changed from

==========
[tracing] Prevent tabbing to some hidden controls

In the 'Record a new trace...' view you can tab to some controls even
when they're hidden behind the 'Edit categories' toggle. To prevent this
we add "display: none" to the container of those controls when they
should be hidden.

BUG=chromium:629480
==========

to

==========
[tracing] Prevent tabbing to some hidden controls

In the 'Record a new trace...' view you can tab to some controls even
when they're hidden behind the 'Edit categories' toggle. To prevent this
we add "display: none" to the container of those controls when they
should be hidden.

BUG=chromium:629480

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-09-28 10:50:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...