Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2372093002: [inspector] fixed console.count with empty stack (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman, alph
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fixed console.count with empty stack BUG=chromium:644629 R=dgozman@chromium.org Committed: https://crrev.com/4dffc8a7008fd80e6b4ccac9ade2dfebe7649b56 Cr-Commit-Position: refs/heads/master@{#39786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/inspector/v8-console.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
kozy
Dmitry, please take a look. Test: https://codereview.chromium.org/2370033003/
4 years, 2 months ago (2016-09-27 02:11:33 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-09-27 16:31:20 UTC) #2
alph
lgtm
4 years, 2 months ago (2016-09-27 16:45:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372093002/1
4 years, 2 months ago (2016-09-27 17:01:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 17:11:24 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:11:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4dffc8a7008fd80e6b4ccac9ade2dfebe7649b56
Cr-Commit-Position: refs/heads/master@{#39786}

Powered by Google App Engine
This is Rietveld 408576698