Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2372043002: [Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState (Closed)
Patch Set: Addressing feedback from dougarnett Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index 891054b43123c20f367c99f6561cfe2429534cea..9e56595c4228ed84e79153f0f20b46a87c36fe62 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -294,26 +294,16 @@ void RequestCoordinator::UpdateRequestCallback(
}
}
-// Called in response to updating multiple requests in the request queue.
void RequestCoordinator::UpdateMultipleRequestsCallback(
- const RequestQueue::UpdateMultipleRequestResults& results,
- std::vector<std::unique_ptr<SavePageRequest>> requests) {
+ std::unique_ptr<UpdateRequestsResult> result) {
+ for (const auto& request : result->updated_items)
+ NotifyChanged(request);
+
bool available_user_request = false;
- for (const auto& request : requests) {
- NotifyChanged(*(request));
- if (!available_user_request && request->user_requested() &&
- request->request_state() == SavePageRequest::RequestState::AVAILABLE) {
- // TODO(dougarnett): Consider avoiding prospect of N^2 in case
- // size of bulk requests can get large (perhaps with easier to consume
- // callback interface).
- for (std::pair<int64_t, RequestQueue::UpdateRequestResult> pair :
- results) {
- if (pair.first == request->request_id() &&
- pair.second == RequestQueue::UpdateRequestResult::SUCCESS) {
- // We have a successfully updated, available, user request.
- available_user_request = true;
- }
- }
+ for (const auto& request : result->updated_items) {
+ if (!available_user_request && request.user_requested() &&
+ request.request_state() == SavePageRequest::RequestState::AVAILABLE) {
+ available_user_request = true;
}
}
« no previous file with comments | « components/offline_pages/background/request_coordinator.h ('k') | components/offline_pages/background/request_queue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698