[Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState

components/offline_pages/background/request_queue_store.h

Index: components/offline_pages/background/request_queue_store.h
diff --git a/components/offline_pages/background/request_queue_store.h b/components/offline_pages/background/request_queue_store.h
index 8504c1b1e43e556504f49406f1e54c5c39d94aec..0df89e51ad5a2016798e53e152c8855bbc46bfa3 100644
--- a/components/offline_pages/background/request_queue_store.h
+++ b/components/offline_pages/background/request_queue_store.h
@@ -15,8 +15,6 @@
 
 namespace offline_pages {
 
-typedef StoreUpdateResult<SavePageRequest> UpdateRequestsResult;
-
 // Interface for classes storing save page requests.
 class RequestQueueStore {
  public:
@@ -26,17 +24,13 @@ class RequestQueueStore {
     FAILED,   // Add or update attempt failed.
   };
 
+  using UpdateCallback = RequestQueue::UpdateCallback;
+
   typedef base::Callback<void(
       bool /* success */,
       std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
       GetRequestsCallback;
   typedef base::Callback<void(ItemActionStatus)> AddCallback;
-  typedef base::Callback<void(std::unique_ptr<UpdateRequestsResult>)>
-      UpdateCallback;
-  typedef base::Callback<void(
-      const RequestQueue::UpdateMultipleRequestResults& /* statuses*/,
-      std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
-      UpdateMultipleRequestsCallback;
   typedef base::Callback<void(
       const RequestQueue::UpdateMultipleRequestResults& /* statuses */,
       std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
@@ -55,7 +49,7 @@ class RequestQueueStore {
 
   // Asynchronously updates requests in store.
   virtual void UpdateRequests(const std::vector<SavePageRequest>& requests,
-                              const UpdateCallback& callback) = 0;
+                              const RequestQueue::UpdateCallback& callback) = 0;

[dougarnett, 2016/09/29 21:02:49]

Is this redundant with the "using" you added on line 27?

[fgorski, 2016/09/30 23:14:35]

Done. Good catch. Thanks.

 
   // Asynchronously removes requests from the store using their IDs.
   // Result of the update, and a number of removed pages is passed in the
@@ -65,13 +59,6 @@ class RequestQueueStore {
   virtual void RemoveRequests(const std::vector<int64_t>& request_ids,
                               const RemoveCallback& callback) = 0;
 
-  // Asynchronously changes the state of requests from the store using their
-  // request id.
-  virtual void ChangeRequestsState(
-      const std::vector<int64_t>& request_ids,
-      const SavePageRequest::RequestState new_state,
-      const UpdateMultipleRequestsCallback& callback) = 0;
-
   // Resets the store.
   virtual void Reset(const ResetCallback& callback) = 0;
 };