[Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState

components/offline_pages/background/change_requests_state_task_unittest.cc

Index: components/offline_pages/background/change_requests_state_task_unittest.cc
diff --git a/components/offline_pages/background/change_requests_state_task_unittest.cc b/components/offline_pages/background/change_requests_state_task_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e215d4efbfffbfe1f801019af65701605af690d7
--- /dev/null
+++ b/components/offline_pages/background/change_requests_state_task_unittest.cc
@@ -0,0 +1,149 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/offline_pages/background/change_requests_state_task.h"
+
+#include <memory>
+
+#include "base/bind.h"
+#include "base/test/test_simple_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "components/offline_pages/background/request_queue_in_memory_store.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace offline_pages {
+namespace {
+const int64_t kRequestId1 = 42;
+// const int64_t kRequestId2 = 43;

[Pete Williamson, 2016/09/27 23:49:56]

Let's remove or comment in (and use) the commented out code here.

[fgorski, 2016/09/28 22:39:06]

Done.

+const int64_t kRequestId3 = 44;
+const GURL kUrl1("http://example.com");
+// const GURL kUrl2("http://another-example.com");
+const ClientId kClientId1("bookmark", "1234");
+// const ClientId kClientId2("async", "5678");
+}  // namespace
+
+class ChangeRequestsStateTaskTest : public testing::Test {
+ public:
+  ChangeRequestsStateTaskTest();
+  ~ChangeRequestsStateTaskTest() override;
+
+  void PumpLoop();
+
+  void SetUpStore(RequestQueueStore* store);
+
+  void AddRequestDone(ItemActionStatus status);
+
+  void ChangeRequestsStateCallback(
+      std::unique_ptr<UpdateRequestsResult> result);
+
+  UpdateRequestsResult* last_result() const { return result_.get(); }
+
+ private:
+  std::unique_ptr<UpdateRequestsResult> result_;
+  scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+  base::ThreadTaskRunnerHandle task_runner_handle_;
+};
+
+ChangeRequestsStateTaskTest::ChangeRequestsStateTaskTest()
+    : task_runner_(new base::TestSimpleTaskRunner),
+      task_runner_handle_(task_runner_) {}
+
+ChangeRequestsStateTaskTest::~ChangeRequestsStateTaskTest() {}
+
+void ChangeRequestsStateTaskTest::PumpLoop() {
+  task_runner_->RunUntilIdle();
+}
+
+void ChangeRequestsStateTaskTest::SetUpStore(RequestQueueStore* store) {
+  base::Time creation_time = base::Time::Now();
+  SavePageRequest original_request(kRequestId1, kUrl1, kClientId1,
+                                   creation_time, true);
+  store->AddRequest(original_request,
+                    base::Bind(&ChangeRequestsStateTaskTest::AddRequestDone,
+                               base::Unretained(this)));
+  PumpLoop();
+}
+
+void ChangeRequestsStateTaskTest::AddRequestDone(ItemActionStatus status) {
+  ASSERT_EQ(ItemActionStatus::SUCCESS, status);
+}
+
+void ChangeRequestsStateTaskTest::ChangeRequestsStateCallback(
+    std::unique_ptr<UpdateRequestsResult> result) {
+  result_ = std::move(result);
+}
+
+TEST_F(ChangeRequestsStateTaskTest, UpdateWhenStoreEmpty) {
+  RequestQueueInMemoryStore store;
+  std::vector<int64_t> request_ids{kRequestId1};
+  ChangeRequestsStateTask task(
+      &store, request_ids, SavePageRequest::RequestState::PAUSED,
+      base::Bind(&ChangeRequestsStateTaskTest::ChangeRequestsStateCallback,
+                 base::Unretained(this)));
+  task.Run();
+  PumpLoop();
+  ASSERT_TRUE(last_result());
+  EXPECT_EQ(1UL, last_result()->item_statuses.size());
+  EXPECT_EQ(kRequestId1, last_result()->item_statuses[0].first);
+  EXPECT_EQ(ItemActionStatus::NOT_FOUND,
+            last_result()->item_statuses[0].second);
+  EXPECT_EQ(0UL, last_result()->updated_items.size());
+}
+
+TEST_F(ChangeRequestsStateTaskTest, UpdateSingleItem) {

[Pete Williamson, 2016/09/27 23:49:56]

Maybe add a test to update multiple items?

[fgorski, 2016/09/28 22:39:06]

Done.

+  RequestQueueInMemoryStore store;
+  SetUpStore(&store);
+  std::vector<int64_t> request_ids{kRequestId1};
+  ChangeRequestsStateTask task(
+      &store, request_ids, SavePageRequest::RequestState::PAUSED,
+      base::Bind(&ChangeRequestsStateTaskTest::ChangeRequestsStateCallback,
+                 base::Unretained(this)));
+  task.Run();
+  PumpLoop();
+  ASSERT_TRUE(last_result());
+  EXPECT_EQ(1UL, last_result()->item_statuses.size());
+  EXPECT_EQ(kRequestId1, last_result()->item_statuses[0].first);
+  EXPECT_EQ(ItemActionStatus::SUCCESS, last_result()->item_statuses[0].second);
+  EXPECT_EQ(1UL, last_result()->updated_items.size());
+  EXPECT_EQ(SavePageRequest::RequestState::PAUSED,
+            last_result()->updated_items[0].request_state());
+}
+
+TEST_F(ChangeRequestsStateTaskTest, EmptyRequestsList) {
+  RequestQueueInMemoryStore store;
+  std::vector<int64_t> request_ids;
+  ChangeRequestsStateTask task(
+      &store, request_ids, SavePageRequest::RequestState::PAUSED,
+      base::Bind(&ChangeRequestsStateTaskTest::ChangeRequestsStateCallback,
+                 base::Unretained(this)));
+  task.Run();
+  PumpLoop();
+  ASSERT_TRUE(last_result());
+  EXPECT_EQ(0UL, last_result()->item_statuses.size());
+  EXPECT_EQ(0UL, last_result()->updated_items.size());
+}
+
+TEST_F(ChangeRequestsStateTaskTest, UpdateMissingItem) {
+  RequestQueueInMemoryStore store;
+  SetUpStore(&store);
+  std::vector<int64_t> request_ids{kRequestId1, kRequestId3};
+  ChangeRequestsStateTask task(
+      &store, request_ids, SavePageRequest::RequestState::PAUSED,
+      base::Bind(&ChangeRequestsStateTaskTest::ChangeRequestsStateCallback,
+                 base::Unretained(this)));
+  task.Run();
+  PumpLoop();
+  ASSERT_TRUE(last_result());
+  EXPECT_EQ(2UL, last_result()->item_statuses.size());
+  EXPECT_EQ(kRequestId1, last_result()->item_statuses[0].first);
+  EXPECT_EQ(ItemActionStatus::SUCCESS, last_result()->item_statuses[0].second);
+  EXPECT_EQ(kRequestId3, last_result()->item_statuses[1].first);
+  EXPECT_EQ(ItemActionStatus::NOT_FOUND,
+            last_result()->item_statuses[1].second);
+  EXPECT_EQ(1UL, last_result()->updated_items.size());
+  EXPECT_EQ(SavePageRequest::RequestState::PAUSED,
+            last_result()->updated_items[0].request_state());
+}
+
+}  // namespace offline_pages