[Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState

components/offline_pages/background/request_queue_store_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/request_queue_store.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 40 matching lines @@
   void PumpLoop();
   void ClearResults();
 
   // Callback used for get requests.
   void GetRequestsDone(bool result,
                        std::vector<std::unique_ptr<SavePageRequest>> requests);
   // Callback used for add/update request.
   void AddOrUpdateDone(UpdateStatus result);
   void AddRequestDone(ItemActionStatus status);
   void UpdateRequestDone(std::unique_ptr<UpdateRequestsResult> result);
-  void UpdateMultipleRequestsDone(
-      const RequestQueue::UpdateMultipleRequestResults& results,
-      std::vector<std::unique_ptr<SavePageRequest>> requests);
   // Callback used for remove requests.
   void RemoveDone(const RequestQueue::UpdateMultipleRequestResults& results,
                   std::vector<std::unique_ptr<SavePageRequest>> requests);
   // Callback used for reset.
   void ResetDone(bool result);
 
   LastResult last_result() const { return last_result_; }
   UpdateStatus last_update_status() const { return last_update_status_; }
   const RequestQueue::UpdateMultipleRequestResults&
   last_multiple_update_results() const {
@@ skipping 68 matching lines @@
 
 void RequestQueueStoreTestBase::AddRequestDone(ItemActionStatus status) {
   last_add_status_ = status;
 }
 
 void RequestQueueStoreTestBase::UpdateRequestDone(
     std::unique_ptr<UpdateRequestsResult> result) {
   last_update_result_ = std::move(result);
 }
 
-void RequestQueueStoreTestBase::UpdateMultipleRequestsDone(
-    const RequestQueue::UpdateMultipleRequestResults& results,
-    std::vector<std::unique_ptr<SavePageRequest>> requests) {
-  last_multiple_update_results_ = results;
-  last_requests_ = std::move(requests);
-}
-
 void RequestQueueStoreTestBase::RemoveDone(
     const RequestQueue::UpdateMultipleRequestResults& results,
     std::vector<std::unique_ptr<SavePageRequest>> requests) {
   last_remove_results_ = results;
   last_requests_ = std::move(requests);
 }
 
 void RequestQueueStoreTestBase::ResetDone(bool result) {
   last_result_ = result ? LastResult::kTrue : LastResult::kFalse;
 }
@@ skipping 202 matching lines @@
   ASSERT_EQ(2ul, this->last_remove_results().size());
   // When requests are missing, we expect the results to say so, but since they
   // are missing, no requests should have been returned.
   ASSERT_EQ(RequestQueue::UpdateRequestResult::REQUEST_DOES_NOT_EXIST,
             this->last_remove_results().at(0).second);
   ASSERT_EQ(RequestQueue::UpdateRequestResult::REQUEST_DOES_NOT_EXIST,
             this->last_remove_results().at(1).second);
   ASSERT_EQ(0UL, this->last_requests().size());
 }
 
-TYPED_TEST(RequestQueueStoreTest, PauseAndResumeRequest) {
-  std::unique_ptr<RequestQueueStore> store(this->BuildStore());
-  base::Time creation_time = base::Time::Now();
-
-  // Create request and add it to the queue.
-  SavePageRequest request1(kRequestId, kUrl, kClientId, creation_time,
-                           kUserRequested);
-  store->AddRequest(request1,
-                    base::Bind(&RequestQueueStoreTestBase::AddRequestDone,
-                               base::Unretained(this)));
-  this->PumpLoop();
-  this->ClearResults();
-
-  // Pause a request.
-  std::vector<int64_t> request_ids{kRequestId};
-  store->ChangeRequestsState(
-      request_ids, SavePageRequest::RequestState::PAUSED,
-      base::Bind(&RequestQueueStoreTestBase::UpdateMultipleRequestsDone,
-                 base::Unretained(this)));
-  ASSERT_EQ(LastResult::kNone, this->last_result());
-  this->PumpLoop();
-
-  // Verify pause succeeded
-  ASSERT_EQ(1ul, this->last_multiple_update_results().size());
-  ASSERT_EQ(RequestQueue::UpdateRequestResult::SUCCESS,
-            this->last_multiple_update_results().at(0).second);
-  ASSERT_EQ(kRequestId, this->last_requests().at(0)->request_id());
-  this->ClearResults();
-
-  // Get the request from the queue to check it out
-  store->GetRequests(base::Bind(&RequestQueueStoreTestBase::GetRequestsDone,
-                                base::Unretained(this)));
-  this->PumpLoop();
-  ASSERT_EQ(LastResult::kTrue, this->last_result());
-  // The request should still be in the queue.
-  ASSERT_EQ(1UL, this->last_requests().size());
-  // Request 1 should be paused.
-  ASSERT_EQ(SavePageRequest::RequestState::PAUSED,
-            this->last_requests().at(0)->request_state());
-  this->ClearResults();
-
-  // Now resume the same request we paused.
-  store->ChangeRequestsState(
-      request_ids, SavePageRequest::RequestState::AVAILABLE,
-      base::Bind(&RequestQueueStoreTestBase::UpdateMultipleRequestsDone,
-                 base::Unretained(this)));
-  ASSERT_EQ(LastResult::kNone, this->last_result());
-  this->PumpLoop();
-
-  // Verify resume succeeded.
-  ASSERT_EQ(1ul, this->last_multiple_update_results().size());
-  ASSERT_EQ(RequestQueue::UpdateRequestResult::SUCCESS,
-            this->last_multiple_update_results().at(0).second);
-  ASSERT_EQ(kRequestId, this->last_requests().at(0)->request_id());
-  this->ClearResults();
-
-  // Get the request from the queue to check it out
-  store->GetRequests(base::Bind(&RequestQueueStoreTestBase::GetRequestsDone,
-                                base::Unretained(this)));
-  this->PumpLoop();
-  ASSERT_EQ(LastResult::kTrue, this->last_result());
-  // The request should still be in the queue.
-  ASSERT_EQ(1UL, this->last_requests().size());
-  // Request 1 should be paused.
-  ASSERT_EQ(SavePageRequest::RequestState::AVAILABLE,
-            this->last_requests().at(0)->request_state());
-  this->ClearResults();
-}
-
 TYPED_TEST(RequestQueueStoreTest, ResetStore) {
   std::unique_ptr<RequestQueueStore> store(this->BuildStore());
   base::Time creation_time = base::Time::Now();
   SavePageRequest original_request(
       kRequestId, kUrl, kClientId, creation_time, kUserRequested);
   store->AddRequest(original_request,
                     base::Bind(&RequestQueueStoreTestBase::AddRequestDone,
                                base::Unretained(this)));
   this->PumpLoop();
   this->ClearResults();
@@ skipping 35 matching lines @@
   store->GetRequests(base::Bind(&RequestQueueStoreTestBase::GetRequestsDone,
                                 base::Unretained(this)));
   ASSERT_EQ(LastResult::kNone, this->last_result());
   this->PumpLoop();
   ASSERT_EQ(LastResult::kTrue, this->last_result());
   ASSERT_EQ(1ul, this->last_requests().size());
   ASSERT_TRUE(original_request == *(this->last_requests().at(0).get()));
 }
 
 }  // offline_pages