Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: third_party/WebKit/Source/core/frame/Location.idl

Issue 2371993003: Throw when blocking top-level navigation. (Closed)
Patch Set: Test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Location.idl
diff --git a/third_party/WebKit/Source/core/frame/Location.idl b/third_party/WebKit/Source/core/frame/Location.idl
index 7f541abe742feb64bb94acb2ba5c89ead58448f5..a2760f6536d75beee8f4d18b982cbe0c365a836e 100644
--- a/third_party/WebKit/Source/core/frame/Location.idl
+++ b/third_party/WebKit/Source/core/frame/Location.idl
@@ -48,17 +48,17 @@
// TODO(foolip): Per spec, Location implements URLUtils. The below is
// mostly like the URLUtils interface, but with some members missing and
// using DOMString instead of USVString.
- [SetterCallWith=(CurrentWindow,EnteredWindow), DoNotCheckSecurity=Setter] attribute DOMString href;
+ [SetterCallWith=(CurrentWindow,EnteredWindow), DoNotCheckSecurity=Setter, RaisesException=Setter] attribute DOMString href;
[NotEnumerable, ImplementedAs=href] DOMString toString();
readonly attribute DOMString origin;
[SetterCallWith=(CurrentWindow,EnteredWindow), RaisesException=Setter] attribute DOMString protocol;
- [SetterCallWith=(CurrentWindow,EnteredWindow)] attribute DOMString host;
- [SetterCallWith=(CurrentWindow,EnteredWindow)] attribute DOMString hostname;
- [SetterCallWith=(CurrentWindow,EnteredWindow)] attribute DOMString port;
- [SetterCallWith=(CurrentWindow,EnteredWindow)] attribute DOMString pathname;
- [SetterCallWith=(CurrentWindow,EnteredWindow)] attribute DOMString search;
- [SetterCallWith=(CurrentWindow,EnteredWindow)] attribute DOMString hash;
+ [SetterCallWith=(CurrentWindow,EnteredWindow), RaisesException=Setter] attribute DOMString host;
+ [SetterCallWith=(CurrentWindow,EnteredWindow), RaisesException=Setter] attribute DOMString hostname;
+ [SetterCallWith=(CurrentWindow,EnteredWindow), RaisesException=Setter] attribute DOMString port;
+ [SetterCallWith=(CurrentWindow,EnteredWindow), RaisesException=Setter] attribute DOMString pathname;
+ [SetterCallWith=(CurrentWindow,EnteredWindow), RaisesException=Setter] attribute DOMString search;
+ [SetterCallWith=(CurrentWindow,EnteredWindow), RaisesException=Setter] attribute DOMString hash;
// TODO(foolip): Location does not have a valueOf() override in the spec.
// See the comment in Location.h for the purpose of this.

Powered by Google App Engine
This is Rietveld 408576698