Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 2371993003: Throw when blocking top-level navigation. (Closed)
Patch Set: Test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_per_process_browsertest.cc
diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
index 80c95ff99ac5d34d5842621b0052d0d123cde54d..69e6bb00ee4389af6034528c904326d3063d676f 100644
--- a/content/browser/site_per_process_browsertest.cc
+++ b/content/browser/site_per_process_browsertest.cc
@@ -3769,9 +3769,9 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, OriginUpdatesReachProxies) {
// frames[1] can't be used due to a bug where RemoteFrames are created out of
// order (https://crbug.com/478792). Instead, target second frame by name.
- EXPECT_TRUE(ExecuteScript(
- root->child_at(0),
- "parent.frames['frame2'].location.href = 'data:text/html,foo'"));
+ EXPECT_TRUE(ExecuteScript(root->child_at(0),
+ "try { parent.frames['frame2'].location.href = "
+ "'data:text/html,foo'; } catch (e) {}"));
console_delegate->Wait();
std::string frame_origin = root->child_at(1)->current_origin().Serialize();

Powered by Google App Engine
This is Rietveld 408576698