Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2371983002: Prefer loading Smi 0 instead of null into a runtime call result slot. (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prefer loading Smi 0 instead of null into a runtime call result slot. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/f2a5c7157cd73f2e98d4d84915d7516f9aaf4921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -136 lines) Patch
M runtime/vm/stub_code_arm.cc View 15 chunks +24 lines, -20 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 15 chunks +19 lines, -20 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 15 chunks +12 lines, -34 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 14 chunks +18 lines, -29 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 15 chunks +23 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 2 months ago (2016-09-26 22:11:08 UTC) #2
Florian Schneider
lgtm
4 years, 2 months ago (2016-09-26 22:16:17 UTC) #3
rmacnak
4 years, 2 months ago (2016-09-26 22:40:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f2a5c7157cd73f2e98d4d84915d7516f9aaf4921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698