Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2371933004: Commit observatory's pubspec.lock to the repo (Closed)

Created:
4 years, 2 months ago by Bill Hesse
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak, Cutch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Commit observatory's pubspec.lock to the repo It is no longer generated, since we have checked in .packages rather than generating it. Pub build requires it to be there. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/0f0bd64ca42c2eab15c4a07a8aaffde130646fff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -1 line) Patch
M runtime/observatory/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
A runtime/observatory/pubspec.lock View 1 chunk +251 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
4 years, 2 months ago (2016-09-27 11:11:27 UTC) #2
Bill Hesse
4 years, 2 months ago (2016-09-27 11:14:40 UTC) #4
Johnni Winther
lgtm
4 years, 2 months ago (2016-09-27 11:27:22 UTC) #5
Bill Hesse
4 years, 2 months ago (2016-09-27 12:04:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f0bd64ca42c2eab15c4a07a8aaffde130646fff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698