Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2371933003: Fix paint invalidation for composited vertical-rl having overflow (Closed)
Patch Set: pixel snapping looks incorrect Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutView.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp
index bb9eb0ea9d9fd927f44b756ad3b2879672bcff85..163b080f0a3e9fb01aba8677eb5d5c8385698892 100644
--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp
@@ -294,7 +294,7 @@ LayoutRect LayoutView::visualOverflowRect() const
// In normal compositing mode, LayoutView doesn't actually apply clipping
// on its descendants. Instead their visual overflow is propagated to
// compositor()->m_rootContentLayer for accelerated scrolling.
- return LayoutRect(documentRect());
+ return layoutOverflowRect();
}
LayoutRect LayoutView::localOverflowRectForPaintInvalidation() const
@@ -822,6 +822,7 @@ IntRect LayoutView::documentRect() const
{
LayoutRect overflowRect(layoutOverflowRect());
flipForWritingMode(overflowRect);
+ // TODO(crbug.com/650768): The pixel snapping looks incorect.
chrishtr 2016/09/27 18:55:20 nit: "incorrect"
Xianzhu 2016/09/27 20:48:38 Done.
return pixelSnappedIntRect(overflowRect);
}

Powered by Google App Engine
This is Rietveld 408576698