Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(25)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/composited-vertical-rl-overflow.html
Issue
2371933003
:
Fix paint invalidation for composited vertical-rl having overflow (Closed)
Patch Set: -
Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/paint/invalidation/composited-vertical-rl-overflow.html
third_party/WebKit/LayoutTests/paint/invalidation/composited-vertical-rl-overflow-expected.html
third_party/WebKit/LayoutTests/paint/invalidation/composited-vertical-rl-overflow-expected.txt
third_party/WebKit/LayoutTests/paint/invalidation/vertical-rl-overflow.html
third_party/WebKit/LayoutTests/paint/invalidation/vertical-rl-overflow-expected.html
third_party/WebKit/LayoutTests/paint/invalidation/vertical-rl-overflow-expected.txt
third_party/WebKit/Source/core/layout/LayoutView.cpp
third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/paint/invalidation/composited-vertical-rl-overflow-expected.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<style>
3
#div {
4
will-change: transform;
5
box-shadow: -50px 0 red;
6
position: absolute;
7
top: 100px;
8
left: 100px;
9
width: 100px;
10
height: 100px;
11
writing-mode: vertical-rl;
12
background-color: blue;
13
}
14
</style>
15
Tests paint invalidation of a composited verticle-rl div with overflow. Passes i f no under-invalidation reported and shows no red.
16
<div id="div"></div>
17
<script src="resources/text-based-repaint.js"></script>
18
<script>
19
function repaintTest() {
20
div.style.boxShadow = '-50px 0 green';
21
}
22
onload = runRepaintAndPixelTest;
23
</script>
OLD
NEW
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/paint/invalidation/composited-vertical-rl-overflow-expected.html »
('j') |
no next file with comments »
Issue 2371933003: Fix paint invalidation for composited vertical-rl having overflow (Closed)
Created 4 years, 2 months ago by Xianzhu
Modified 4 years, 2 months ago
Reviewers: chrishtr, wkorman
Base URL:
Comments: 8
This is Rietveld
408576698
Chromium Code Reviews
Issue 2371933003:
Fix paint invalidation for composited vertical-rl having overflow (Closed)
